On Authentic Theme settings the Password generator
field has the following description:
Set the length and character type used in the generated password. Default value equals to 12|a-z,A-Z,0-9,#, which represents password with 12 characters in length, containing upper and lower case letters, numbers and special characters. First value is numerical, which is the length of the password, immediately followed by | as a delimiter. Next is the type, where you can use numbers 0-9, letters a-z and/or A-Z, and special characters #. All of these sets can be used together or individually, using comma as a delimiter.
and when we set something like 16|a-z,A-Z,0-9,#
then it works wonderfully generating various complex passwords like, for example, @d|~0w*LBWr6rmFL
.
On the other hand Virtualmin Configuration page offers the following option and description under the Defaults for new domains
section:
By default, randomly generated passwords will contain only upper and lower case letters and the digits 0 to 9. However, this field can be used to enter an alterative list of characters to use, such as abcdefghijklmnopqrstuvwxyz_-.0123456789 .
So we have to go with either the Default (A-Z, a-z, 0-9)
which, unfortunately, does not include special characters, or put really long list of all possible characters like all the letters in lower case, and then upper case and the long list of all the special characters one by one. Please re-code so users could something shorter, for example regex, for input value of this field or just use the same approach that Ilia used in Authentic Theme. Anyway it would be really good from usability point of both Virtualmin and Authentic Theme offered all the same options.
Thanks for consideration
Comments
Submitted by andreychek on Thu, 11/01/2018 - 14:19 Comment #1
Submitted by yngens on Thu, 11/01/2018 - 14:19 Comment #2
By the way, if I am not mistaken the word
alterative
in the help text should be replaced withalternative
.Submitted by JamieCameron on Fri, 11/02/2018 - 01:11 Comment #3
Assigning this to Ilia - I actually didn't realize that the theme had it's own password generator.
Actually, there is a word
alterative
, and it fits quite well to the sentence used. Unless Jamie or Joe think it's not okay, I will keep it.Done.
I've never heard/seen the word "alterative". My browser spell-checker thinks it's not a word. I would have assumed typo, as well. ;-)
I also had no idea the theme had a password generator. This might be feature creep. Is there no way to consolidate all password generation to one configuration location?
I was thinking about it today. I started looking at the code, and it seems Virtualmin dependent.
If, Jamie could factor out this subroutine, and add this somewhere under WebminCore, then yes, we could use one configuration for it, under Webmin and theme could read it.
Submitted by yngens on Mon, 11/05/2018 - 07:40 Comment #9
Yes, by context I say that word was supposed to be "alternative". Anyway, Ilia, form your last post I believe this has not been fixed yet as James needs to act, right? So I am marking it back to Active, correct me if I am wrong.
I will double check and let you know.
Okay, yes,
random_password
is part of Virtualmin, and if could be factored out, with its config added somewhere under Webmin Configuration, then I could completely drop configuration for password on the theme side.The reason why it should be under Webmin, rather than be left under Virtualmin, is that password generator used under all modules and works even without installing Virtualmin module.
Submitted by yngens on Mon, 11/05/2018 - 13:52 Comment #12
Ok then let's change the issue project back to Webmin, so that Jamie could take a look at this once again.