Remove extra unnecessary upload buttons on Upload and Download page

Not sure if this bug belongs to Authentic theme or Webmin core, but if you go to Webmin > Others > Upload and Download page then you will see four upload buttons next to "Files to upload" option. First I thought they were provided to uploading multiple files, however when I clicked just one of them and selected several files, then it accepted them all as shown on the screenshot. So just one upload button would be sufficient.

Status: 
Active

Comments

Joe's picture
Submitted by Joe on Mon, 10/15/2018 - 20:49 Pro Licensee

This is sort of a historic thing...and is still necessary for some browsers. It was to allow multiple uploads, but Authentic provides for multi-uploads from a single chooser button using newer browser features. I'm not sure whether we should change it in the theme or in Webmin core...the extra buttons come from Webmin, but they are only not useful in Authentic, so...

I'll think on it for a bit and check in a fix somewhere to make the change. This is one of those things where I'm tempted to wait to change it until after the vast majority of browsers have caught up (which may already be the case, but people often surprise me with how often they use really old software). I don't know exactly when the features used for multi-upload came along, but will check in with Ilia to see.

Joe's picture
Submitted by Joe on Mon, 10/15/2018 - 20:52 Pro Licensee

Actually, it looks like old theme also supports multi-uploads in browsers that support it, so the change should happen in Webmin core. The question is how many users will we make grump if we remove the extras? I'm looking into it. (I don't really want to do feature sniffing to serve different pages, unless it's something where there's a lot of divergence across popular browsers.)

Body: View changes
I'll think on it for a bit and check in a fix somewhere to make the change. This is one of those things where I'm tempted to wait to change it until after the vast majority of browsers have caught up (which may already be the case, but people often surprise me with how often they use really old software). I don't know exactly when the features used for multi-upload came along, but will check in with Ilia to see.

I would like to believe *min family is specialty software and its users must be tech-savvy at some level. If there are rare users who still use IE 1 then they are already screwed up and they should not be using *min at all. I mean you, guys, should think hosting industry companies as your main customer base, not some individual users who stuck in Jurassic age.

Anyway, we are perfectly fine with the current state, it's your call what to do. I am just reporting every inconsistency I stumble upon using *min.

Joe's picture
Submitted by Joe on Tue, 10/16/2018 - 00:31 Pro Licensee

You'd be surprised. We have users complaining about Authentic not supporting IE 11 fully, even though that browser is five years old and has been mostly abandoned by Microsoft. Likewise, we get complaints about not supporting old (really old!) Outlook and Thunderbird versions all the time. I don't like it, but we do somewhat have to support whatever is in common use. This is a newer feature than five years, for sure, but might not be rare enough to justify keeping the extraneous buttons.