Does webmin support ZFS file system

Submitted by Ted Sikorski on Sat, 05/28/2016 - 08:00 Pro Licensee

I am seeing the following errors in my miniserv.error log:

The feature@ properties must be appended with a feature name. See zpool-features(5). invalid option 'p' usage: list [-gHLPv] [-o property[,...]] [-T d|u] [pool] ... [interval [count]]

the following properties are supported:

    PROPERTY         EDIT   VALUES

    allocated          NO   <size>
    capacity           NO   <size>
    dedupratio         NO   <1.00x or higher if deduped>
    expandsize         NO   <size>
    fragmentation      NO   <percent>
    free               NO   <size>
    freeing            NO   <size>
    guid               NO   <guid>
    health             NO   <state>
    leaked             NO   <size>
    size               NO   <size>
    altroot           YES   <path>
    ashift            YES   <ashift, 9-13, or 0=default>
    autoexpand        YES   on | off
    autoreplace       YES   on | off
    bootfs            YES   <filesystem>
    cachefile         YES   <file> | none
    comment           YES   <comment-string>
    dedupditto        YES   <threshold (min 100)>
    delegation        YES   on | off
    failmode          YES   wait | continue | panic
    listsnapshots     YES   on | off
    readonly          YES   on | off
    version           YES   <version>
    feature@...       YES   disabled | enabled | active

The feature@ properties must be appended with a feature name. See zpool-features(5). "

And webmin is not reporting anything on the ZFS disk that I have allocated to this system. Running Centos 7 with Cloudmin 9.0Pro.

Thanks.

Status: 
Closed (fixed)

Comments

Submitted by andreychek on Sat, 05/28/2016 - 09:22

Howdy -- thanks for all the information you provided! Just a couple more questions --

just to clarify, which system is it that's running ZFS? Is that the Cloudmin host, or one (or more) of the guests?

And then where is that error occurring in the miniserv.error? Is that on the host or the guest(s)?

Thanks!

Submitted by Ted Sikorski on Mon, 05/30/2016 - 10:43 Pro Licensee

Hi,
I only have one system so far the cloudmin-master
the error messages that I am seeing are from the miniserv.error.
I haven't created any virtual systems yet. Still trying to debug a Docker issue on another item.

Submitted by Ted Sikorski on Mon, 05/30/2016 - 10:47 Pro Licensee

If I issue the command
#zpool list -p
I get the error messages that I am seeing in the miniserv.log

If I enter the command
zpool list -P
I get reasonable output.
I suspect that someone mistyped an option in a zpool list command.

Ted

Submitted by Ted Sikorski on Mon, 05/30/2016 - 11:28 Pro Licensee

Hi,
Line 307
Should look like:

my @out = &backquote_command("zpool list -P");

in file
/usr/libexec/webmin/mount/mount-lib.pl

Submitted by JamieCameron on Mon, 05/30/2016 - 17:22

What does the zpool list -P command output on your system?

Submitted by Ted Sikorski on Tue, 05/31/2016 - 03:26 Pro Licensee

[root@cloudmin-master server-manager]# zpool list -P
NAME SIZE ALLOC FREE EXPANDSZ FRAG CAP DEDUP HEALTH ALTROOT
zpool-docker 199G 262M 199G - 0% 0% 1.00x ONLINE -

Submitted by Ted Sikorski on Tue, 05/31/2016 - 03:27 Pro Licensee

[root@cloudmin-master server-manager]# zpool list -p
invalid option 'p'
usage:
list [-gHLPv] [-o property[,...]] [-T d|u] [pool] ... [interval [count]]

the following properties are supported:

PROPERTY EDIT VALUES

allocated NO <size>
capacity NO <size>
dedupratio NO <1.00x or higher if deduped>
expandsize NO <size>
fragmentation NO <percent>
free NO <size>
freeing NO <size>
guid NO <guid>
health NO <state>
leaked NO <size>
size NO <size>
altroot YES <path>
ashift YES <ashift, 9-13, or 0=default>
autoexpand YES on | off
autoreplace YES on | off
bootfs YES <filesystem>
cachefile YES <file> | none
comment YES <comment-string>
dedupditto YES <threshold (min 100)>
delegation YES on | off
failmode YES wait | continue | panic
listsnapshots YES on | off
readonly YES on | off
version YES <version>
feature@... YES disabled | enabled | active

The feature@ properties must be appended with a feature name.
See zpool-features(5).

Submitted by Ted Sikorski on Tue, 05/31/2016 - 03:31 Pro Licensee

It appears -P is the default

[root@cloudmin-master server-manager]# zpool list
NAME SIZE ALLOC FREE EXPANDSZ FRAG CAP DEDUP HEALTH ALTROOT
zpool-docker 199G 262M 199G - 0% 0% 1.00x ONLINE -
[root@cloudmin-master server-manager]# zpool list -P
NAME SIZE ALLOC FREE EXPANDSZ FRAG CAP DEDUP HEALTH ALTROOT
zpool-docker 199G 262M 199G - 0% 0% 1.00x ONLINE -

Submitted by JamieCameron on Tue, 05/31/2016 - 19:06

Thanks - so if you change the code to use -P instead of -p , does it fix the problem?

Submitted by JamieCameron on Wed, 06/01/2016 - 23:26

Great - this fix will be in the next release of Webmin.

Submitted by JamieCameron on Wed, 06/01/2016 - 23:26

Status: Active » Fixed

Submitted by crea7or on Thu, 12/01/2016 - 19:35

A lot errors in /var/log/webmin/miniserv.error

The feature@ properties must be appended with a feature name. See zpool-features(7). invalid option 'P' usage: list [-Hpv] [-o property[,...]] [-T d|u] [pool] ... [interval [count]]

Changing &backquote_command("zpool list -P")

to

&backquote_command("zpool list -p")

in /usr/local/lib/webmin/mount/mount-lib.pl

fixes the problem :)

Submitted by crea7or on Mon, 01/30/2017 - 16:25

Forgot to mention OS in previous report - Freebsd 11

output from zpool list -P

zpool list -P

invalid option 'P' usage: list [-Hpv] [-o property[,...]] [-T d|u] [pool] ... [interval [count]]

the following properties are supported:

    PROPERTY         EDIT   VALUES

    allocated          NO   <size>
    capacity           NO   <size>
    dedupratio         NO   <1.00x or higher if deduped>
    expandsize         NO   <size>
    fragmentation      NO   <percent>
    free               NO   <size>
    freeing            NO   <size>
    guid               NO   <guid>
    health             NO   <state>
    leaked             NO   <size>
    size               NO   <size>
    altroot           YES   <path>
    autoexpand        YES   on | off
    autoreplace       YES   on | off
    bootfs            YES   <filesystem>
    cachefile         YES   <file> | none
    comment           YES   <comment-string>
    dedupditto        YES   <threshold (min 100)>
    delegation        YES   on | off
    failmode          YES   wait | continue | panic
    listsnapshots     YES   on | off
    readonly          YES   on | off
    version           YES   <version>
    feature@...       YES   disabled | enabled | active

The feature@ properties must be appended with a feature name. See zpool-features(7).

output from zpool list -p

zpool list -p

no pools available

Submitted by JamieCameron on Mon, 01/30/2017 - 19:46

Yeah, the latest release of Webmin should be able to handle this discrepency.

Submitted by bajobongo on Thu, 09/14/2017 - 08:17

Now it is broken for FreeBSD (RELEASE), where -p is OK and -P is invalid... I see that in mentioned mount-lib.pl is: my @out = &backquote_command("zpool list -P || zpool list -p"); The first try of execution make this log fully...

Submitted by JamieCameron on Thu, 09/14/2017 - 20:27

If you run zpool list -P does it fail with a non-zero exit code?

Submitted by bajobongo on Fri, 09/15/2017 - 03:04

# zpool list -P
invalid option 'P'
usage:
        list [-Hpv] [-o property[,...]] [-T d|u] [pool] ... [interval [count]]

the following properties are supported:

        PROPERTY         EDIT   VALUES

        allocated          NO   <size>
        capacity           NO   <size>
        dedupratio         NO   <1.00x or higher if deduped>
        expandsize         NO   <size>
        fragmentation      NO   <percent>
        free               NO   <size>
        freeing            NO   <size>
        guid               NO   <guid>
        health             NO   <state>
        leaked             NO   <size>
        size               NO   <size>
        altroot           YES   <path>
        autoexpand        YES   on | off
        autoreplace       YES   on | off
        bootfs            YES   <filesystem>
        cachefile         YES   <file> | none
        comment           YES   <comment-string>
        dedupditto        YES   <threshold (min 100)>
        delegation        YES   on | off
        failmode          YES   wait | continue | panic
        listsnapshots     YES   on | off
        readonly          YES   on | off
        version           YES   <version>
        feature@...       YES   disabled | enabled | active

The feature@ properties must be appended with a feature name.
See zpool-features(7).

# echo $?
2

Logfile contains the whole zpool list -P invalid output message.

Submitted by JamieCameron on Sat, 09/16/2017 - 15:49

Ok, so since Webmin runs zpool list -P || zpool list -p , it should still get the list of pools on any system.

Submitted by bajobongo on Mon, 10/02/2017 - 02:50

Yes, it is, but the problem is that log file grows very fast without important reason.

Submitted by JamieCameron on Mon, 10/02/2017 - 19:10

Good point - I'll fix that