DNS: Check for trailing ";"

Hey guys,

in BIND configs, statements are completed with a ";". If one uses Webmin to manage BIND, Webmin automatically adds this ";". Although that's a useful behaviour, it can lead to wrong configuration-entries if the user adds the ";" manually.

I.e. adding an ACL entry like: "key key_default;" will become "key key_default;;" which will end in an error, because BIND expects a value between the two ";".

tl;tr: please check if the user has completed the BIND config entries with a ";" and only add it if it's missing.

Thank you.

Status: 
Closed (fixed)

Comments

Thanks for pointing this out - I will fix Webmin in the next release (1.550) to disallow ; in this case, as it is always added automatically..

Automatically closed -- issue fixed for 2 weeks with no activity.