Please support CIDR Postfix maps

I have the following directive in my postfix configuration:

smtpd_client_restrictions = permit_inet_interfaces check_client_access hash:/opt/local/etc/postfix/whiteblacklist_mx check_client_access cidr:/opt/local/etc/postfix/postfix-dnswl-permit

Followed by a bunch a blacklists. When I go to the SMTP CLient Restrictions" screen, it says "This map cannot be edited : Webmin does not support the map type check_client_access cidr"

So, either, it doesn't support cidr, or, it doesn't support more than 1 list, not sure which.

This is used by the DNSWL that you should consider using also in your Virtualmin system install. The DNSWL whitelists known good mail servers (including ours) as is specified before the list of blacklists as some are too aggressive. It's wonderful project that Spamassassin uses by default.

Status: 
Closed (fixed)

Comments

Joe's picture
Submitted by Joe on Sun, 03/28/2010 - 12:47 Pro Licensee

While I have no problem with Webmin supporting this option (Webmin modules try to support every valid configuration file for the services it manages), I don't think having Postfix do the DNSBL processing, by default, is particularly wise. SpamAssassin can assign weights to things that are notoriously prone to false positives (like DNSBLs), making it possible to use them without getting bitten by them. Since false positives are something that causes a hellfire of scorn to rain down upon us from angry Virtualmin users, we don't go down roads that will lead to more false positives. ;-)

So, that'll have to be something you do of your own free will (but, again, I certainly don't have a problem with Webmin being able to manage those options).

Yes, I do understand. But, DNSWL is a WHITELIST, not a blacklist, by itself, it would not lead to a single false positive.

Still, all I am asking for is the cidr type be supported.

I'll take a look at this .. it does look like Webmin is not supporting the cidr map type properly.

I've just updated the code, and this will be supported in Webmin 1.520.

Automatically closed -- issue fixed for 2 weeks with no activity.