File Manager Editor can't save files after last *min update

Submitted by Blueforce on Sun, 03/14/2021 - 20:28 Pro Licensee

Hi,

After latest Virtualmin/Webmin update the File Manager Editor no longer can save files! The progress spinner never stops and files cant be saved, neither old or new.

And also most files now gets recognized as "RPM Spec".

I urgently need File Manager Editor to be able to edit and save files again!

Best regards, Leffe

Status: 
Active
Virtualmin version: 
6.15
Webmin version: 
1.973

Comments

Submitted by JamieCameron on Sun, 03/14/2021 - 21:08

What type of file are you trying to save (text, HTML, etc) ?

Submitted by Blueforce on Sun, 03/14/2021 - 21:22 Pro Licensee

Hi, It was a plain text file, actually a spamassasin.conf file, but it doesn't matter wat file type, txt, php, js, html or what ever - no files can be saved!

Ilia's picture
Submitted by Ilia on Mon, 03/15/2021 - 04:00

If you open browser's console when trying to save the file -- do you get any error message?

If you force reload browser's page or better try incognito tab - does it solve your problem?

What files (which file extension) are detected as "RPM Specs" and where are those files located exactly?

Submitted by Blueforce on Mon, 03/15/2021 - 05:47 Pro Licensee

Hi Ilia,

I get a error in bundle.min.js:415:5700 "TypeError: e.replaceAll is not a function".

I also get "SyntaxError: invalid identity escape in regular expression" in bundle.min.js:418:40615, but that error also exist on our other server that I haven't updated yet and there save still works.

Reload or incognito does not make any difference.

The files that recognized as "RPM Specs" was init.pre and local.cf in etc/mail/spamassassin/

Best regards, Leffe

Ilia's picture
Submitted by Ilia on Mon, 03/15/2021 - 05:55

What is your browser version?

Submitted by Blueforce on Mon, 03/15/2021 - 06:18 Pro Licensee

I don't know right now, I'll check when I'm at that computer later today, I know it has a bit older ESR 32-bit version. Do you think that can be the reason? Everything works on another server not yet updated.

Ilia's picture
Submitted by Ilia on Mon, 03/15/2021 - 06:22

Yes, you should update the browser to the latest version on the regular basis. Perhaps it would work somehow on 3-4 y.o. browser but with 5-7 y.o. won't work most likely. And it's insecure too.

I suggest using the latest version of Firefox or Chrome.

I would like to know exactly what browser version do you have?

Ilia's picture
Submitted by Ilia on Mon, 03/15/2021 - 06:46

I have made a patch that should fix this problem. Use theme configuration page to update to the latest devel version and see if it works for you.

Submitted by Blueforce on Mon, 03/15/2021 - 07:41 Pro Licensee

Thanks Ilia,

I have checked Firefox version on the computer that I used, it's a computer uniquely used for connecting to the servers. That still run a old Firefox ESR version, 52.9.0 from late 2018! (I think updates was stopped for this one to be able to run the old JS file manager a few years back.) All our other computers always run the latest versions of firefox!

I can also confirm that everything works just fine on the latest FF version.

I'll change my working computer to new one running the latest standard Firefox version.

I also updated another server and downloaded ver 19.74-1 for testing with the old browser but the result is the same, no save. But you shouldn't need to "fix" this since it works perfectly on a up to date browser.

Thanks for your help Ilia!