Scheduled Backup attempts to delete same S3 bucket twice (and fails) [#70364]

Submitted by karl578 on Mon, 12/14/2020 - 08:47

My scheduled backup is attempting (and failing) to delete an old enough bucket twice. The first deletion attempt succeeds but the logs show a second attempt to delete the same bucket. This causes the backup to 'fail' since the bucket no longer exists.

Deleting backups from Amazon S3 bucket my_virtualmin.example.com.daily.%d.%m.%Y-%H.%M older than 7 days ..
   Deleting S3 bucket my_virtualmin.example.com.daily.06.12.2020-02.00, which is 8 days old ..
   .. deleted 178.51 MiB.

   Deleting S3 bucket my_virtualmin.example.com.daily.06.12.2020-02.00, which is 8 days old ..
   .. deletion failed :
An error occurred (NoSuchBucket) when calling the ListObjectsV2 operation: The specified bucket does not exist

I have awscli installed.

Why is there a second attempt to delete the same bucket? Is this a strftime issue? I'm using %d.%m.%Y-%H.%M

Thanks

Karl.

Status:

Fixed (pending)

Virtualmin version:

6.14

Webmin version:

1.962

Comments

Submitted by JamieCameron on Fri, 12/18/2020 - 13:54 Comment #1

Can you post a screenshot of your scheduled backup page, showing the destination and purging options?

Submitted by karl578 on Fri, 12/18/2020 - 22:06 Comment #2

The incremental daily backup (the one with the issue): https://i.imgur.com/6gSCqZd.png

The full weekly backup: https://i.imgur.com/kr8zEhB.png

Hope this is helpful. I've had trouble trying to find any logs that'll help me understand what's causing the issue.

Submitted by JamieCameron on Sat, 12/19/2020 - 14:50 Comment #3

Seems like the bug here is that Virtualmin is finding the same bucket twice.

Do you have the aws command installed on your system? If so, what output do you get if you run aws ls ?

Submitted by karl578 on Sun, 12/20/2020 - 20:30 Comment #4

Seems like the bug here is that Virtualmin is finding the same bucket twice.

Yes.

Yes aws is installed.

Is there any way to output the aws command logs to see what's happening?

Submitted by JamieCameron on Sun, 12/20/2020 - 21:10 Comment #5

You could just run aws ls and see if it outputs the same bucket twice?

Submitted by karl578 on Mon, 12/21/2020 - 10:36 Comment #6

Nope. aws s3 ls doesn't list any bucket twice.

2020-12-14 02:00:09 my-domains.com.daily.14.12.2020-02.00
2020-12-15 02:00:05 my-domains.com.daily.15.12.2020
2020-12-16 02:00:09 my-domains.com.daily.16.12.2020
2020-12-17 02:00:09 my-domains.com.daily.17.12.2020
2020-12-18 02:00:08 my-domains.com.daily.18.12.2020
2020-12-19 02:00:09 my-domains.com.daily.19.12.2020
2020-12-20 02:00:07 my-domains.com.daily.20.12.2020
2020-12-21 02:00:09 my-domains.com.daily.21.12.2020
2020-12-01 02:29:37 my-domains.com.weekly.01.12.2020-02.29
2020-12-06 01:49:03 my-domains.com.weekly.06.12.2020-01.48
2020-12-13 01:00:08 my-domains.com.weekly.13.12.2020-01.00
2020-12-20 01:00:08 my-domains.com.weekly.20.12.2020

Does the cli command virtualmin backup-domain log the aws output when it makes use of it?

I'll try to run a test backup from the command line later to see what happens.

Submitted by JamieCameron on Mon, 12/21/2020 - 15:42 Comment #7

Never mind, I looked closer at the code and found a bug that can cause buckets to be listed twice! We'll fix this in the next release.

Submitted by karl578 on Tue, 12/22/2020 - 09:14 Comment #8

Ah, ok. Cool.

Thanks for your time. Look forward to the next release.