Submitted by isdahlc on Mon, 01/21/2019 - 15:41 Pro Licensee
Guys,
Noticed this on one of our gpl servers - this is a very lightweight server and is only used to manage our dns zones. Was in the webmin menu and noticed this section (Webmin Servers Index) is greyed out and not accessible. Nothing's been done to this server on our end except normal os/virtualmin updates.
Operating system Ubuntu Linux 18.04.1
Webmin version 1.900
Usermin version 1.741
Virtualmin version 6.04 Authentic theme version 19.21
Perl version 5.026001
Path to Perl /usr/bin/perl
BIND version 9.11Status:
Closed (fixed)
Comments
Submitted by JamieCameron on Tue, 01/22/2019 - 20:21 Comment #1
That's unusual - are you running Cloudmin on that system, or just Virtualmin?
Submitted by isdahlc on Thu, 01/24/2019 - 13:22 Pro Licensee Comment #2
Cloudmin
Interestingly enough, I took a snapshot of that server and setup a fresh copy for a test I'm doing - the link is not disabled in the copy...
Submitted by JamieCameron on Fri, 01/25/2019 - 00:02 Comment #3
Ilia, in what situations does the theme grey out a module link like that?
It should only happen on the instance that has already been opened via Webmin Servers Index module.
What is the comple URL of the server, where you're seeing the link being striked-out, like in the screenshot?
Yes, I have double checked and the link is not active (line-through) in case the server is already opened using Webmin Servers Index module.
We don't expect using Webmin Servers Index in nested way, as agreed in the past. Jamie is this correct?
Submitted by isdahlc on Fri, 01/25/2019 - 07:40 Pro Licensee Comment #6
Ilia,
Here is the URL I think you are asking for, if this isn't right let me know.
https://vmcp2.dashsystems.com:10000/servers/link.cgi/154109629614830/sysinfo.cgi?xnavigation=1So this is coming from our Cloudmin system to the target server (cp.dashsystems.com).
Yes, correct. This URL already opened using Webmin Servers Index module.
Submitted by isdahlc on Fri, 01/25/2019 - 08:07 Pro Licensee Comment #8
I'm not sure I'm following but the greyed out link is on the target machine - I should be able to manage webmin servers there.
So we are all on the same page... I login into Cloudmin, I select the target server and clieck "open webmin". A new tab opens and I'm now on the target server - on this server is where webmin servers is greyed out.
We are not seeing this behavior on any other servers at this time.
It's a bit confusing for me now.
Jamie, is this possible/valid to have such URL, for example: localhost:10000/servers/link.cgi/1548399322/servers/link.cgi/1548440556/
I remember we discussed that using Webmin Servers Index is only okay, when used once, for example from source->target, but not from source->target->new subtarget.
@isdahlc okay, I have made a fix, let's see how it works for you? Please go to theme configuration and force-update the theme to the latest development version. I would like to hear your feedback, as soon as possible.
Submitted by isdahlc on Fri, 01/25/2019 - 15:03 Pro Licensee Comment #10
Yep that link works now!! And theme looks good!!! Thanks!
The link works but do you expect adding/opening a server from over there? Does it also work?
Submitted by isdahlc on Fri, 01/25/2019 - 16:03 Pro Licensee Comment #12
My bad... when I forced the update I did it to the wrong server - in fact I tried a couple times to do the update (linking to virtualmin from Cloudmin) and it won't do the update - it updates the theme on cloudmin.
I manually loaded the site and to do the update and received the attached warning.
It means you need to update Webmin to version 1.900 at least on target machine.
There are some issues when using Webmin Servers Index in nested way. I will try to find the way to fix it.
I have done more tests. If you go to theme configurtion using navigation menu, instead of using a gear icon from Dashboard, then things will work fine for you. Dashboard is receiving the wrong link when in Servers Index module.
Aside from this bug, anything else that doesn't work for you? :)
If something doesn't work, please post the URL, at which things break. (You don't need to include hostname:port).
I have fixed linking issue on the latest commit.
I just want to make sure that we're talking about the same issue here, which I believe is not yet resolved, for nested usage of Webmin Servers Index.
After applying latest update, are there any other issues that you experience?
Submitted by JamieCameron on Sat, 01/26/2019 - 12:38 Comment #16
Nested use of the webmin servers index module is intentionally not supported - the proxying method that webmin uses can't expand beyond a single level of forwarding.
Doesn't it mean then, that the link should not be displayed then, as before?
What would be the best solution from your point of view? Maybe nested Webmin Servers Index, when used (clicked on the icon to open the host), could give a warning?
Submitted by isdahlc on Sat, 01/26/2019 - 13:40 Pro Licensee Comment #18
v1.900 is already installed on that system (see original post). I still see that warning when using theme configuration from navigation menu.
I'm not following the "nested" conversation but want to be clear - from Cloudmin I select the server I want in the dropdown, then clicking "open webmin" from the navigation menu. That opens a new tab showing virtualmin for that server. I go to webmin and "webmin servers index" so I can setup slave DNS servers.
Now the "webmin servers index" is working - it's no longer "crossed out"
Does it opened linked server with no issue?
How does your URL look like after doing above?
Submitted by isdahlc on Sat, 01/26/2019 - 19:02 Pro Licensee Comment #20
Yes
Here is a url after clicking the server link in Webmin Servers Index on the target machine (e.g. In Cloudmin -> Open Webmin -> go to Webmin Servers Index -> click a server link)
https://cp.dashsystems.com:10000/servers/link.cgi/1540997678/Are you saying that this link was grayed out (line-through) for you before previous theme update?
...and one more - is this 'root' login or system owner login? What is the output of the following command in browser's console?
get_server_data('access-level')I am all the way confused now.
Jamie, I tried the old theme (Virtualmin Framed Theme) and it does work with nested Webmin Servers Index just fine!?
Even triple times is just fine.
I will try to make it work as well then.
Jamie, can
$ENV{'HTTP_WEBMIN_PATH'}(remember I asked you about adding it in the past) contain info about nested servers index?For example, the link that is passed to URL is
/servers/link.cgi/1548399322/servers/link.cgi/1548671852/but it gets stored inHTTP_WEBMIN_PATHonly as/servers/link.cgi/1548671852. I don't even need host information and port, only thepathname?Submitted by isdahlc on Tue, 01/29/2019 - 11:59 Pro Licensee Comment #25
Yes, that is correct
Yes this is a "root" user. No output on the command you asked me to run...
[DASHAdmin@cp ~]# get_server_data('access-level')[DASHAdmin@cp ~]#
This command
get_server_data('access-level')should be run in browser's console.Submitted by JamieCameron on Sun, 02/03/2019 - 18:32 Comment #27
I just checked in a Webmin fix that should allow the theme to deal with nested servers.
I also added the patch to support new env variable. https://github.com/authentic-theme/authentic-theme/commit/0543a08adb706c...
Submitted by IssueBot on Thu, 02/28/2019 - 09:07 Comment #30
Automatically closed - issue fixed for 2 weeks with no activity.