ssl.combined incorrectly formatted, missing end of line between certs

Submitted by Lucian on Tue, 09/11/2018 - 05:44

Hello,

I ended up today on a ssl update with the following error in the ssl.combined file (which I use with Nginx on top of Apache, but that's another story):

7A2R2aE2CCxYWGKW+d674dz2SlAs413TsCf3jCwyWPFrPnSvH74ukEUP3+oQeNfT ftMt5FVdYpuXND6dsQ2S -----END CERTIFICATE----------BEGIN CERTIFICATE----- MIIEsTCCA5mgAwIBAgIQCKWiRs1LXIyD1wK0u6tTSTANBgkqhkiG9w0BAQsFADBh

I guess there needs to be a check that there should be a new line following END CERTIFICATE or something like that.

Status: 
Closed (fixed)

Comments

Submitted by andreychek on Tue, 09/11/2018 - 10:59

Assigned: Unassigned »

Passing this along to Jamie for review.

Submitted by JamieCameron on Wed, 09/12/2018 - 13:09

Thanks - Virtualmin assumed that all cert files would end with a newline, but clearly that's not the case. I will fix this in the next release.

Submitted by IssueBot on Thu, 10/11/2018 - 20:07

Status: Fixed (pending) » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.