letsencrypt autorenew do not call the hooks

Submitted by gadnet@aqueos.com on Fri, 05/05/2017 - 10:59

hi,

when requesting a lets encrypt cert the system call the

"Command to run before making changes to a server" and "Command to run after making changes to a server"

with the ACTION VIRTUALSERVER_ACTION=SSL_DOMAIN but the autometed renewall of the lets encrypt certificate do not call them.

I use those hook to configure an haproxy protection in front of sites and so i cannot propagate the certificate to haproxy on the renewall.

Therefor any ssl config done is not propagated by those hooks and the websites are not working anymore after the 90 days.

As the creation call those hooks with the ACTION VIRTUALSERVER_ACTION=SSL_DOMAIN this seems a bug to me that the renewall does not :)

best regards, ghislain

Status: 
Closed (fixed)

Comments

Submitted by gadnet@aqueos.com on Tue, 05/09/2017 - 02:47

Of course when i say sites do not works after 90 days i mean if you use the pre/post hook to configure something else like a proxy for exemple.

If you have no use for the pre/post hook the thing works but then the very existance of the hooks:

"Command to run before making changes to a server" and "Command to run after making changes to a server"

is not as usefull as it was.

regards, Ghislain.

Submitted by gadnet@aqueos.com on Tue, 05/09/2017 - 02:51

i should add if you look at the hooks call that SSL_CA is not correctly set when requesting a cert lets encrypt. It is empty but should not be.

Submitted by JamieCameron on Tue, 05/09/2017 - 11:23

Thanks for pointing this out - this will be fixed in the next Virtualmin release.

Submitted by JamieCameron on Tue, 05/09/2017 - 11:23

Status: Active » Fixed

Submitted by gadnet@aqueos.com on Wed, 05/10/2017 - 08:36

Thanks a lot for this quick answer, you rocks guys ! :)

Submitted by IssueBot on Wed, 05/24/2017 - 08:42

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.