Controversial recommendation by Authentic Theme

Submitted by yngens on Sat, 11/19/2016 - 04:27

Today I've got the following message from Authentic Theme:

Detected that you are using en.UTF-8 character set and not utf-8, which is strongly recommended. Strange  character might appear in text-editor mode and/or other encoding issues are going to happen. Change language in Virtualmin Configuration to en.UTF-8 and make sure, that your browser also detected it correctly.

Note the recommendation to set "utf-8" in the first sentence goes against the recommendation for "en.UTF-8" in the second sentence. Please make up your mind between the two and set the correct message.

Status: 
Closed (fixed)

Comments

Joe's picture
Submitted by Joe on Sat, 11/19/2016 - 05:21 Pro Licensee

Assigned: Unassigned »

Ilia's picture
Submitted by Ilia on Sat, 11/19/2016 - 05:38

Hi,

Obviously it's not intended and should only appear if you don't have utf8 set.

What is your current charset?

Submitted by JamieCameron on Sat, 11/19/2016 - 14:05

A recommendation to use the en.UTF-8 language instead of just en wouldn't be unreasonable. In fact, recent Webmin installs use eu.UTF-8 by default.

Submitted by yngens on Sat, 11/19/2016 - 16:15

You guys seem to miss the subject matter. Read carefully the first and then the second sentence of the message given and then you will understand : the first one suggest one thing, the second one - completely another thing.

Submitted by dlynes on Sat, 11/26/2016 - 09:01 Pro Licensee

@yngens is saying that authentic theme is saying that he's using UTF-8, but then suggesting that he's not and he should be. (i.e. utf-8 vs en.UTF-8)

Ilia's picture
Submitted by Ilia on Sun, 11/27/2016 - 12:06

Hi,

I have made stricter checkups. This message will only show up when you don't use uft* charset for any of the languages.

Thanks for reporting.

It will be enhanced in 18.30.

Ilia's picture
Submitted by Ilia on Sun, 11/27/2016 - 12:06

Status: Active » Closed (fixed)

Submitted by yngens on Thu, 12/01/2016 - 19:27

Well, I believe my point is totally missed. Ilya, just translate two sentences into Russian and you will see it.

Ты пойми, что первое предложение строго рекомендует utf-8, а второе - наоборот en.UTF-8.

Compare

utf-8, which is strongly recommended

with

Change language in Virtualminr Configuration to en.UTF-8

Submitted by yngens on Thu, 12/01/2016 - 19:28

Status: Closed (fixed) » Active
Body: View changes

Have to open this again as the point is missed again.

Ilia's picture
Submitted by Ilia on Thu, 12/01/2016 - 23:13

Hi,

:)

I have understood to what you were saying after the first glance. I have written this.

What should never be happening is that you have: Detected that you are using "en.UTF-8"..., it always should be non-utf string, like: Detected that you are using "en"....

I have no idea how did this happen on your side that you're having this message to appear. Strings were converted to lowercase() before comparison prosidure.

Can you tell me what are the settings in:

  1. Webmin->Webmin Configuration->Language
  2. Webmin->Change Language and Theme
  3. Virtualmin.

I will try to reproduce it. However, I tweaked code a bit already but still I don't see how it happened on your side. This message shouldn't have appeared at the first place.

What browser are you using?

Ilia's picture
Submitted by Ilia on Thu, 12/01/2016 - 23:17

I think it's better to change the sentence to just saying: Detected that you are using non-unicode charset...

Ilia's picture
Submitted by Ilia on Thu, 12/01/2016 - 23:18

..but still, what you should have had is en in the first part and not en.UTF8

Ilia's picture
Submitted by Ilia on Fri, 12/02/2016 - 01:13

Status: Active » Closed (fixed)