Add verbal (in additiona to numerical ones) selection identifiers to Roundcube versions in the installation script

Submitted by yngens on Thu, 10/20/2016 - 00:20

While the following virtualmin CLI command successfully installs the latest version of phpMyAdmin:

virtualmin install-script --type phpmyadmin --domain db.$VIRTUALSERVER_DOM --version latest --path / --user $VIRTUALSERVER_MYSQL_USER --pass $VIRTUALSERVER_PASS

the similar command for Rouncube fails:

virtualmin install-script --type roundcube --domain mail.$VIRTUALSERVER_DOM --version latest --path / --db mysql $VIRTUALSERVER_DB"_mail" --user $VIRTUALSERVER_MYSQL_USER --pass $VIRTUALSERVER_PASS

I believe while indicating the latest version for phpMyAdmin works, doing the same for Roubcube does not. To compare, these are select options and you can see phpMyAdmin selector besides numerical versions has verbal ones in parenthesis while Rouncube selector has only numerical ones. I am not sure if that is the reason, but it would be great to be able to indicate verbal versions like latest, stable, old for Roundcube too, because the numerical ones periodically change and not good to use in scripts.

<select class="ui_select" name="ver_phpmyadmin" id="ver_phpmyadmin">
<option value="4.6.4">4.6.4 (Latest)</option>
<option value="4.4.15.8">4.4.15.8 (Stable)</option>
<option value="4.0.10.17">4.0.10.17 (Old)</option>
<option value="3.5.8.2">3.5.8.2 (Un-supported)</option>
</select> <select class="ui_select" name="ver_roundcube" id="ver_roundcube">
<option value="1.2.2">1.2.2</option>
<option value="1.0.9">1.0.9</option>
<option value="0.8.7">0.8.7</option>
</select>
Status: 
Closed (fixed)

Comments

Submitted by JamieCameron on Thu, 10/20/2016 - 09:58

The --version latest option should work for all scripts - I just tested this for the Roundcube installer, and it worked fine for me.

What is the error message you're getting from the install-script API?

Submitted by yngens on Thu, 10/20/2016 - 10:29

My bad, the issue was incorrect setting for --db mysql and not about --version. Anyway, can you add those (Latest) type in parentheses for RoundCube too, or remove them from phpMyAdmin, to keep things consistent?

Submitted by JamieCameron on Thu, 10/20/2016 - 19:33

Does Roundcube document the support level for its various versions?

Submitted by yngens on Fri, 10/21/2016 - 22:38

Not sure. But I thought those support level descriptions for phpMyAdmin comes from your party as I remember your correcting user-unfriendly things like Really old or was it Ancient or something like that.

Submitted by JamieCameron on Fri, 10/21/2016 - 18:42

I checked, and I will add those labels for roundcube versions in the next release.

Submitted by JamieCameron on Fri, 10/21/2016 - 18:43

Status: Active ยป Fixed