Authentic Theme does not respect some custom URL, logo settings

Hi Ilya,

Thank you very much for the excellent job done on Authentic Theme. Now as it has officially became part of *min family, if you don't mind we will start reporting issues related to it here at https://virtualmin.com.

If you click on Virtualmin > System Settings > Virtualmin Confugration then you will find some settings like, for example, "URL for company logo image", "Link destination for company logo", "Alt text for company logo", "Link destination for additional documentation", "Link title for additional documentation", which are totally ignored and so not functional on the new theme at all.

I believe if Authentic Theme wants to become the official *min theme then it should respect all the settings present there. So we suggest to either consider non-functional settings as obsolete and totally get rid of them or to somehow integrate them into the new theme.

Thanks for considering.

Status: 
Closed (fixed)

Comments

I am reading now what fakemoth wrote on https://www.virtualmin.com/node/34315#comment-140769 regarding this matter back on 2014-11-24:

We (I) used to have nice personalized logos, for Webmin/Virtualmin and Usermin authentication page, and also inside the panels after logging in, left-upper corner, individualized per server and so on. You know, that our clients can enjoy (not) :) or at least remember our company. How do we add those?

however I am afraid you never elaborated on that particular part.

Joe's picture
Submitted by Joe on Wed, 01/06/2016 - 20:44 Pro Licensee

We're discussing how to bring the logo back without screwing up the display. I lean toward a footer in the left menu, it could be fixed so it doesn't scroll off the screen when scrolling the menu, perhaps. Putting it above the Webmin/Virtualmin tabs seems like it would be ugly, but maybe we'll tinker with that before deciding on what to do.

We'll keep maintaining the old theme for the foreseeable future, so you won't be stuck without a theme that can do that. But, we wanted to get this one out to everyone ASAP, now that it's proven to be quite reliable in a few hundreds (maybe thousands) of installations.

I agree that it's important in some deployments, especially for folks selling hosting and wanting to remind folks who they are!

As an aside, I've occasionally seen folks stick logos without transparency and mismatched colors in there...that's a no-no! Hopefully folks will use a nice PNG with transparency or an SVG, when we do get this one sorted out. If people ruin Authentic theme's good looks, it'll make Joe a very sad panda.

Ilia's picture
Submitted by Ilia on Thu, 01/07/2016 - 10:14

I technically could remove all logo-related options in Virtualmin configuration as the theme has it's own logo control. And I will unless asked otherwise.

I just don't know if it's important to add ability to place custom logos of different types in the panels? If there is a great need I could do it but at first I need to see the screenshot and I didn't find anything related to how to place custom logos to panels ("...inside the panels after logging in, left-upper corner..." and so on).

Please attach the screenshot. I will comment to that old thread to bring more attention.

I will fix Link destination for additional documentation and Link title for additional documentation, that should work.

The logo by default will stay at the bottom and will always be visible. There is also an ability to setup logo for login page.

I can also make logos clickable with the defined link if needed.

Please take a look at the theme logo existing control and the way it work no. It doesn't disturb links as well. Is there anything wrong here, Yngens? https://rostovtsev.ru/pub/src/authentic/17.xx/39225/logo_usage_and_appea...

Not at all, it really looks nice.

I technically could remove all logo-related options in Virtualmin configuration as the theme has it's own logo control. And I will unless asked otherwise.

Please do so as all we as a hosting vendor want is stability and absence of any ambiguities, because you should agree - if there is a setting in UI it should have some effect or it should be completely eliminated.

I will fix Link destination for additional documentation and Link title for additional documentation, that should work.

Please do so.

Thanks!

Ilia's picture
Submitted by Ilia on Fri, 02/19/2016 - 01:18

Assigned: Unassigned »
Status: Active » Closed (fixed)