Failed to save resource limits : Missing or invalid memory limit

Submitted by yngens on Fri, 10/10/2014 - 22:40

Setting memory accidentally to bytes with decimal fractions in Cloudmin UI outputs the error:

Error
Failed to save resource limits : Missing or invalid memory limit

Call Stack Trace

File Line Function
/usr/libexec/webmin/server-manager/save_limits.cgi 19 WebminCore::error
(eval 21) 6 (eval)
/usr/libexec/webmin/miniserv.pl 2361 (eval)
/usr/libexec/webmin/miniserv.pl 909 miniserv::handle_request
Status: 
Closed (fixed)

Comments

Submitted by JamieCameron on Sat, 10/11/2014 - 01:17

That actually seems pretty reasonable - there's no such thing as a fraction of a byte!

Submitted by yngens on Sat, 10/11/2014 - 11:09

That actually seems pretty reasonable - there's no such thing as a fraction of a byte!

I see that. It's just the error message looks ugly and like Cloudmin is brkone. Maybe you can add a check and sanitize the variable against accidental entries by users bytes with decimal (or other extra characters).

Marking this as closed in case if you believe there is no need to sanitize.