Reseller Quota Does Not Apply

Dear Developers!

We've found that - since don't know which version - reseller accounts quota setting stopped applying.

Resellers definitely can assign more quota summary for their managed virtual servers than the quota setting at Virtualmin » System Settings / Reseller Accounts » Username » Reseller's limits / Maximum quota for all servers. This is the main problem and think can be a bug.

Otherwise Master Admin also can assign more quota summary for Resellers' managed virtual servers than the quota setting at Virtualmin » System Settings / Reseller Accounts » Username » Reseller's limits / Maximum quota for all servers. This is not a real problem but don't know if is a bug or not.

Please help us to let - at least - our main problem to solve.

Many thanks and greetings.

Gergo GICZY Hungary/EU

Status: 
Closed (fixed)

Comments

I just tested this, and found that reseller quota limits are being applied. For example, I had a reseller with a 5 GB limit and 4 GB of quota already handed out, and when I tried to create a domain as that reseller with a 2 GB quota it correctly failed..

By what method are your resellers going over their quota limit?

Well Jamie,

I forgot to tell that it just happens when a Reseller updates (obviously increase) an existing virtual server quota. In this case that is enabled overcommitting.

I'm sorry we did not tested by creating new servers as our resellers cannot create new domains according to the old-school paperwork way of domain registration in our little but beloved country.

I just tested increasing an existing domain's too, and the reseller quota limit still applied..

Which page was this on, and what did they enter in each of the quota fields exactly?

Currently for a Reseller at Virtualmin » System Settings / Reseller Accounts » Username » Reseller's limits / Maximum quota for all servers there is 48 GB limit. The remark is also "Currently 48 GB".

When that Reseller updates a virtual server at Virtualmin » Servername / Edit Virtual Server » Quotas and limits / Total server quota from 1 GB to 2 GB it "succeeds" (the Server administrator's quota is Unlimited) and the above remark changes to "Currently 49 GB" while the Maximum quota for all servers still contains the original 48 GB limit.

When checked for the group of the virtual server the updated quota becomes active.

The update can be much more addition it doesn't matter.

Update:

I cannot update by any big size of addition. With the above 48 GB Reseller limit:

I set up for a Reseller's virtual server 120 GB without problem. But when I tried to set up for the same virtual server 500 GB, I've got the "Failed to modify server : The server quota cannot be set to more than your reseller maximum remaining of 168 GB." error message. Remarkable that the original Reseller's limit 48 GB AND the set up virtual server's quota 120 GB are exact summary of the error messaged 168 GB.

Then I set up for that Reseller's virtual server 160 GB without problem. But when I tried to set up for the same virtual server 500 GB, I've got the "Failed to modify server : The server quota cannot be set to more than your reseller maximum remaining of 208 GB." error message. Remarkable that the original Reseller's limit 48 GB AND the set up virtual server's quota 160 GB are exact summary of the error messaged 208 GB.

The alive limit seems to be updated by the addition of the unallowable set up while the original setting displayed at Virtualmin » System Settings / Reseller Accounts » Username » Reseller's limits / Maximum quota for all servers remains the same.

Ok, that is definitely a bug.

In these examples, does the reseller have multiple domains, or just one?

Update #2:

It seems there is basically (when not overcommitting) 1 GB gap between the alive limit and the setting in our case.

Because when I tried to set up more than 1 GB unallowable addition I've got the "Failed to modify server : The server quota cannot be set to more than your reseller maximum remaining of 49 GB." while the Virtualmin » System Settings / Reseller Accounts » Username » Reseller's limits / Maximum quota for all servers set up for 48 GB. If I update just the +1 GB unallowable addition for the virtual server, the Reseller's alive limit changes to 50 GB by the above error message. This way I can increase the unallowable quota just by keeping below the error message alive limit which increases with every addition.

Can it be desynced because we have taken away some virtual servers from that Reseller earlier (unfortunately don't know which version). Currently we run v3.80.Pro.

Update #2:

It seems there is basically (when not overcommitting) 1 GB gap between the alive limit and the setting in our case.

Because when I tried to set up more than 1 GB unallowable addition I've got the "Failed to modify server : The server quota cannot be set to more than your reseller maximum remaining of 49 GB." while the Virtualmin » System Settings / Reseller Accounts » Username » Reseller's limits / Maximum quota for all servers set up for 48 GB. If I update just the +1 GB unallowable addition for the virtual server, the Reseller's alive limit changes to 50 GB by the above error message. This way I can increase the unallowable quota just by keeping below the error message alive limit which increases with every addition.

Can it be desynced because we have taken away some virtual servers from that Reseller earlier (unfortunately don't know which version). Currently we run v3.80.Pro.

Sorry for the duplication. I've got server error and retried...

Well, that Reseller has 34 top-level virtual servers with the summary of 48 GB group quota counted by hand.

Do any of this reseller's domains perhaps have the quota set to "unlimited" ? This might have been done by root ..

No, definitely not. Every virtual servers has exact quota set up, alltogether a summary of 48 GB.

I did a bunch of testing, but have not been able to re-produce this problem ... even a reseller with multiple domains has his max quota applied correctly.

Which version of Virtualmin are you running there? The latest is 3.81 ..

Currently we run v3.80.Pro.

There are more details of local testing in Comment #7&8.

What do you suggest then?

You should upgrade to 3.81, and see if the problem still happens.

If so, to debug this further I would need access to your system - both as the reseller who is seeing the problem, and root access. Let me know if that is possible..

OK, Jamie, we will upgrade unlike we originally planned to wait for the upcoming 3.82. (We always make a full backup of our system before upgrading anything so it can be done just by late night of a weekend-day as it produces 1-2 hours of downtime.)

Well, giving access to the developers is an option for us to solve the problem.

Let's see what the upgrade does and then the next step. We'll do this on Friday or Saturday.

Unfortunately installing the newest - 3.82 - version did not even solve the problem.

While the currently allocated summary and the displayed allocable reseller quotas are equal the live allocable - the real - reseller quota amount is faulty 1 GB more than those - the needed - values.

Seems they're not sync'ed somehow.

What to do so please?

I think the only way I could debug this further would be to login to your system myself and see what is going wrong, as I can't re-produce this on my test systems..

So someone else reported this issue and gave me access to his system, and I was able to track it down - it happens in some cases when a reseller's domains have sub-servers. The 3.84 Virtualmin release will include a fix.

Wow, Jamie, good news for the New Year. :)

"Unfortunately" the last weeks we did not have so much time to pay attention of the configuration of our system. But - of course - we're ready to give access to if you need it for further investigation.

Otherwise many thanks for informing us about the solution and we're looking forward to the new version.

Ok, let me know if you'd like to get a pre-release version with a fix ..

Well, Jamie, with a big Thank You for the opportunity, we can wait for the next RTM version without problem as we could work around this issue temporarily with the only reseller concerned about.

Otherwise if we can help you by some real testing, we are ready to. But as that server has hundreds of domains in production, we dare to apply any installation or configuration change only on weekend-day nights to face the risk of things go wrong with more time-gap for troubleshooting...

Automatically closed -- issue fixed for 2 weeks with no activity.