extra branding

We can add a company logo and url in VM so why not be able to change the favicon ?

Status: 
Closed (fixed)

Comments

This doesn't work.

You are using frameset and the favicon only shows up in individual pages such as https://heaven.openstream.ch:10000/right.cgi?open=system

but not inside https://heaven.openstream.ch:10000/

<html>
<head> <title>Virtualmin 3.77 on heaven.openstream.ch (Debian Linux 5.0)</title> </head>
<frameset cols='260,*' border=0>
<frame name=left src='left.cgi' scrolling=auto>
<frame name=right src='right.cgi?open=system&auto=status&open=updates&open=common&open=owner&open=reseller' noresize scrolling=auto>
<noframes>
<body>
<p>This page uses frames, but your browser doesn't support them.</p>
</body>
</noframes>
</frameset>
</html>
<code>

So you created your own custom overlay theme? If so, could you email it to me?

no reason to email it... its just 1 file and 1 line.

# cat config
headhtml=<link rel='shortcut icon' href='http://www.openstream.ch/favicon.ico' type='image/x-icon' />

according to the docs...

headhtml HTML that will be included inside the section of each Webmin page.

Which it what its actually doing. It's adding that to each page not the frameset code that is in index.cgi

You're right, that's a bug..

However, as a work-around why not instead just place that favicon.ico file in your overlay theme's directory?

Because the docs do not mention this and second I didn't think of it.

If a favicon can be placed in the overlay why can't it be added to the VM config settings where there logo url is at ?

Placing the favicon in the overlay directory doesn't work

Actually it does work... however the theme does not work under cloudmin + VM installed

What goes wrong exactly when both cloudmin and Virtualmin are installed?

The overlay doesn't work - neither the css or any html

I think I see a case where this could fail - if you select the overlay theme at Webmin -> Change Language and Theme. Instead, select it globally at Webmin -> Webmin Configuration -> Webmin Themes..

Not the case here. I went directly into webmin config then change theme.

It's not just the favicon that isn't working the custom css isn't showing up either after logging in.

Go look yourself. Your normal support login is activated.

In firefox 3.6.2 linux the overlay is not working and I have cleared my cache more then once. If my overlay works in non-CM installs then it should work with CM.

So when I login as virtualmin-support , I see the favicon just fine, and the grey background which is what I presume your overlay CSS applies?

uhh why am I not getting the same friggin thing then ?

bloody hell

Just for shits and giggles I looked at the root user settings under webmin

Personal UI theme was set to vm framed theme instead of the global and I that was it. I unset that to use the global settings and the overlay theme worked.