Submitted by sgrayban on Mon, 07/13/2009 - 21:11
If you save your website passwords you will have a issue when setting up any backups it will save the ftp password and/or the S3 Secret Access Key which really isn't a good thing if you don't know its doing this and saves a wrong password.
It also breaks your VM login password.
Status:
Closed (fixed)
Comments
Submitted by JamieCameron on Mon, 07/13/2009 - 23:43 Comment #1
Do you mean that if you save the password on the Virtualmin login page, that same password gets incorrectly used in the backup login and password fields? That's odd, as I named the HTML fields differently intentionally to avoid this issue.
Which browser are you seeing this on?
Submitted by sgrayban on Mon, 07/13/2009 - 23:46 Comment #2
subject says Firefox :)
Yup the passwords for the VM login gets confused with both the ftp password and the S3 Secret Access Key fields.
Submitted by sgrayban on Mon, 07/13/2009 - 23:51 Comment #3
Let me clarify this...
The password fields for ftp or s3 are saved as the password for the VM login.
Submitted by JamieCameron on Tue, 07/14/2009 - 13:31 Comment #4
I'm not seeing this, even when using Firefox. Which version are you running?
It seems like a Firefox bug if it is auto-completing the wrong fields..
Submitted by sgrayban on Tue, 07/14/2009 - 18:26 Comment #5
Linux version 3.0.11
Submitted by JamieCameron on Tue, 07/14/2009 - 19:54 Comment #6
I have Firefox 3.10 on Linux, and this doesn't happen for me.
It actually used to be a problem in some places in Webmin/Virtualmin due to fields having the same names as those on the login form ("user" and "pass"). But this is not the case on the backup form .. the SSH destination HTML fields are named "dest_suser" and "dest_spath".
So I really can't see why Firefox would be doing this auto-completion, nor how to stop it.
Submitted by sgrayban on Tue, 07/14/2009 - 23:10 Comment #7
Oh well
We should probably modify the in-product password forms to have the autocomplete="off" attribute. This is occasionally cause for confusion. Certainly the Virtualmin Create Domain page and Edit Domain pages should have it.
Submitted by JamieCameron on Wed, 07/15/2009 - 18:36 Comment #9
Good idea .. I'll do that for username and password fields in the next release.
Submitted by sgrayban on Wed, 07/15/2009 - 19:02 Comment #10
username isnt the issue the auto-complete for passwords are