Letsencypt issue after latest webmin upgrade

Submitted by CEEWorld on Sat, 05/13/2017 - 19:25 Pro Licensee

I posted the following on the forums but after review feel that this may be a bug and so have therefore posted here so that it can be looked into properly.

After the latest update of webmin I cannot renew a letsencrypt cert for a virtual server in virtualmin. When selecting virtualmin/domain/manage ssl cert and selecting the letsencrypt tab when clicking get cert this is the output (I changed the domain names for reasons of privacy):

Requesting a certificate for domain.tld, www.domain.tld from Let's Encrypt ..
.. request failed :

usage:
  letsencrypt [SUBCOMMAND] [options] [-d domain] [-d domain] ...

The Let's Encrypt agent can obtain and install HTTPS/TLS/SSL certificates.  By
default, it will attempt to use a webserver both for obtaining and installing
the cert. Major SUBCOMMANDS are:

  (default) run        Obtain & install a cert in your current webserver

  certonly             Obtain cert, but do not install it (aka "auth")
  install              Install a previously obtained cert in a server
  renew                Renew previously obtained certs that are near expiry
  revoke               Revoke a previously obtained certificate
  rollback             Rollback server configuration changes made during install
  config_changes       Show changes made to server config during installation
  plugins              Display information about installed plugins

letsencrypt: error: unrecognized arguments: --preferred-challenges=dns --manual-auth-hook /etc/webmin/webmin/letsencrypt-dns.pl --manual-cleanup-hook /etc/webmin/webmin/letsencrypt-cleanup.pl

This would appear to suggest that the latest webmin 1.840 update which added DNS validation mode for Let's Encrypt certificates has created an issue within virtualmin as before the upgrade which added dns support for letsencrypt within webmin all was working fine.

Many Thanks

Parent issue: 
#51470: lets encrypt problem
Related issues: 
#51550: [Let's Encrypt] Can't create SSL certificate
Status: 
Active

Comments

Submitted by CEEWorld on Sat, 05/13/2017 - 19:30 Pro Licensee

Assigned: » Unassigned

Submitted by JamieCameron on Sun, 05/14/2017 - 11:29

You may need to upgrade the letsencrypt command to the latest version. How did you install it?

Submitted by CEEWorld on Sun, 05/14/2017 - 15:42 Pro Licensee

Lets encrypt was installed by virtualmin itself. I later added letsencrypt directly for use in creating certs for dovecot and postfix although that did not affect being able to renew or get a cert for a site from within virtualmin. All was working fine until the last webmin/usermin upgrade.

If it is not related to the last webmin/virtualmin update what would be the best way to upgrade the letsencrypt command?

Regards.

Submitted by JamieCameron on Mon, 05/15/2017 - 19:19

Another option would be to un-install the letsencrypt command, and delete the /etc/letsencrypt/accounts directory. This will cause Virtualmin to instead use it's built-in Let's Encrypt client.