Hi,
I'll post this question, or maybe it's more request or wish...
The old Java File Manager used a very nice and good view of folders in the left window, and sub-folders and files in the right window. This is the way almost all file managers work today even the non OS default file managers, two panes, folders in the left and sub-folders and files in the right.
The two pane view is a must have if you do much work in the file manager, as I do, we host a number of domains which all runs our own software, and we do all updates on customers domains on a daily basis. Almost normal updates and work is (so far) done with the Java File Manager.
The huge advance with the two panes is that you can expand several virtual domain and have preferred folder open in each one, and when going from one to another you just click your file to work with, and of course, you can leave that window open, drag it do the side and still see the both panes, click another users file in the open tree structure and have both files open for viewing at the same time. Maybe for copy/paste or compare between open file windows. This cant be done in the new File Manager (not yet anyway), the new file manager use a different way of "mowing around" in the file structure. The dropdown breadcrumbs is nice but not when doing much work with the file manager, to do few changes here and there this works just fine. If you do work a lot in the file manager the dropdown bredcrumbs is taking way to much time, and you can not just click a file to open, and then another file in some other users folder without a lot of selecting forth and back, really time consuming, anyway for me that do a lot of changes, updates on several users all the time.
I'm not saying that I don't like the new File Manager, I really do! Ilia is doing a really good job with it! But if I could choose whish one to use for my daily work I dont have to think - I'll choose Java File Manager without hesitation! Anyway as they both are at the moment. I know many of you think I'm crazy for wanting to sticking with "old stuff", but for me its more like "Stuff that do the work fast and easy". File Manager is a work tool for me, and work tools don't have to have lots of "bling" and other fancy stuff in my opinion. I live on the country side, and my car has nice wheels and other nice stuff but my tractor only has things that has a purpose and makes my work easier.
Maybe there could be some setting, like "basic" and "Advanced" for the file manager.
To summarize, I wish for dual panes in file manager, and ability to open multiple popup editor windows at once!
Best regards, Leffe
Comments
Submitted by Blueforce on Sun, 05/07/2017 - 19:20 Pro Licensee Comment #1
Submitted by JamieCameron on Mon, 05/08/2017 - 01:18 Comment #2
Ilia, do you think this could be done?
Jamie, sure, it could.
Leffe, are you aware that we have tabs that you can switch very quickly using keyboard shortcuts?
Let's move our discussion about user jail-mode from /node/52020 here, as it's also feature request. Like I said, choosing things upon the operation is not very correct in my opinion. Pretend you want to do things for and as user
username1? On the main page of File Manager, somewhere in the toolbar (don't know yet), you could choose any user that has login capabilities on your system and simply jail File Manager to this user. Any following operations would run as that user (new file/directory, archive creation/extraction and so on). File permissions would be as that selected user. Once you done, you could choose the other existing used on your system or go back to root.Do you want just file-tree on the left, that would always be opened and correspond with paths in currently opened/selected tabs?
Submitted by Blueforce on Mon, 05/08/2017 - 19:34 Pro Licensee Comment #4
Hi,
Yes, I'm aware of the tabs, and they do make life a bit easier, but still the Java File Managers is so much faster and easier to work with, you have a complete view of everything all the time, also with several edit windows open. And another good thing in JFM is the toolbar, one click for action. The new FM has drop down menus that I don't like, more clicking and selecting. When actions in a toolbar fit in a row one by one I don't get the point of drop downs.
Do you want just file-tree on the left, that would always be opened and correspond with paths in currently opened/selected tabs?Look at the JFM, it works exactly as I want.When working in FM most of the work is uploading and editing files, when editing you don't need to think about owner, it stays the same even after save. When uploading files or uploading and extracting zip files it would be preferred that the uploaded files get folders owner as default (if you don't select another owner)! Having to switch user all the time seems unnecessary. But yes, sometimes you add a new folder or file and in JFM they did get root owner by default, but it's much less work to change owner on those occasions that have to switch all the time for all actions.
I know it's not just me that actually like the JFM and how it is to work with, but at the moment I feel all alone in this ;)
Regards, Leffe
Submitted by Blueforce on Mon, 05/08/2017 - 19:58 Pro Licensee Comment #5
I missed your last post in the closed issue, sorry!
If you still can edit files as it is today I think a one click owner selection could work, IF... the user list can contain just the virtual domain owners(users), otherwise the list gets long with lots of scrolling and/or searching... But I still think the best for upload would be upload as folder owner as default, because I cant see why anyone normally set ownership of files or folders to someone else than folder owner. If you like to change then your one click selection comes in handy.
Regards, Leffe
Leffe, I'll start with ability to switch to certain user for all supported operations. Upload is not part of it at the moment but will be in the future when I add multiple uploads.
For extraction and uploading I'll add a checkbox that would let extracted files to get parent's folder permission.
You don't even need a toolbar and it can be disabled in settings. Because there are, at first - hotkeys (see module's help on top left) and second there is context menu when you click on the row, I hope you knew about it.
Editing multiple files at once by keeping two or more windows together is a must. I was going to do it at the very beginning but it didn't work however I tried. I will come back to try to enroll it over again.
Submitted by Blueforce on Tue, 05/09/2017 - 08:43 Pro Licensee Comment #7
Yes I know about the context menu, although I'm not a big fan on hoover menus, if you are to quick the menu disappears and you have to try again, and maybe again! But not having the static toolbar is not a big issue for me, the drop down menu or context menu works good enough.
When having one or multiple edit windows open they of course must be re-sizable and movable, as it is now the edit window is locked in size and place.
I don't know if I have said before that most of the time I open the Java File Manager in a new tab in my browser, then I have really good view and working space, and don't have to close the JFM just because I need to do something else in Webmin or Virtualmin. JFM is fine to brake out of the frameset to its own browser tab. When working with JFM in its own browser tab the two panes is really comes to its right, really awesome, its like working locally on computes file manager!
Thanks again Ilia, I really, really appreciate all your work!
//Leffe
Here is the user-mode switch. Please try latest Git version.
Tell me how it feels for you. I suppose it'll feel new but works very fast and supports all operations (but uploads).
Details #759
Submitted by Blueforce on Tue, 05/09/2017 - 16:13 Pro Licensee Comment #9
Hi,
The user-mode switch feels OK! And it's a good feature but is it really necessary to list other users than folder and root, because other users don't have permission to add folders or files anyway.
The only things that don't get the folder user is create file-folder and upload! Why cant create folder and files and also upload be as folder owner by default?
I'm sorry, but I have to ask, when are the user-mode switch supposed to used?
Regards, Leffe
You could use it in case you wanted to do things as that other user. Like create a file and get permissions on it as
user1:user1without a need of changing everytime. Or extract an archive or upload a file (in the future).Right now I'm starting to think to make an option, to fall to this user mode automatically, in case root user descends to some of the home dirs, like
/home/user1. It would be more convenient and would ALMOST always be valid.Uploads is not the part of detached interface yet. I'll improve it. Maybe it'll be the next feature to implement.
Submitted by Blueforce on Tue, 05/09/2017 - 18:07 Pro Licensee Comment #11
OK, yes being the right user and get new files and folder to right user from start is a nice thing.
Right now I'm starting to think to make an option, to fall to this user mode automatically, in case root user descends to some of the home dirs, like/home/user1. It would be more convenient and would ALMOST always be valid.Do you mean that when I go to a folder and start working I do my work as folder user as default? If that is the case I really like it, because if you need root user you can change at that time. To get folder user as default is very good instead of having to find the right user from a long list. At the moment our production server do get a list of about 250 users to choose from.Ok, read this comment and screenshot there.
Any time you go to user home directory File Manger will automatically switch mode. You can disabled it in settings to make it manual.
Enjoy! ;)
Submitted by Blueforce on Wed, 05/10/2017 - 17:30 Pro Licensee Comment #13
Hi Ilia!
This is really awesome! Works perfectly and a really fine bonus is that if I upload a zip, the user is still root:root but when I extract it all files and folders get right user... and the zip itself also changes to right user - Fantastic!
A BIG thanks Ilia!
Regards, Leffe
Sure, uploads will work as I port it, by adding multiple uploads.
I'm glad you like it. ;)
Good news. I managed multiple editors work at the same time in File Manager. Panels, besides to being collapseable, will be resizable and movable.
I wanna try to add a cool feature to auto-align them by size with one click. Will see if it's possible.
I'm finishing couple of other improvements on optimization and pushing it to the repo. If I'm lucky, I'll do it within 24 hours.
I would love to hear your response before 18.49 as it will go to upcoming Webmin 1.841and Usermin 1.711.
Regards, Ilia
Alright, uff.
What was added on the latest commit?
jQuery-UIlib completely (improves overall speed)Please give it a try and tell me if you like it!?
Submitted by Blueforce on Sun, 05/14/2017 - 17:19 Pro Licensee Comment #17
Hi Ilia,
Looks and feels good! I like it! But there are a few issues though.
Not possible to scroll if file contents fits in full height window.
You can't get to the end of the file without expanding window to full height.
The window I click on/have in focus should be up in the top layer.
I'll test some more later on!
//Leffe
Leffe, hi.
I understood number 3. But I don't think I understood 1 and 2? What did you mean?
What browser was that for you? I did it in Chrome but also tested it in Firefox.
Submitted by Blueforce on Sun, 05/14/2017 - 18:23 Pro Licensee Comment #19
Ok, I'll try to explain,
When I open a my file that contains 37 rows of code, and have the window smaller so that I don't see all rows, then its not possible to scroll the contents. And that brings me to no 2.
To be able to see or edit the contents in the end of this file I have to expand the window to show all rows. Normally you just scroll to the bottom.
This happens when the rows in the file you open fits in the file manager edit window in full height. You can test this by selecting a file with fewer lines, open it in with browser maximized, and then make your browser smaller and open the file for edit again, and now, if the browser is smaller than the height of the file contents you can scroll the file contents in a smaller edit window.
I use Firefox 52.1.1 ESR 32 bit.
//Leffe
Submitted by Blueforce on Sun, 05/14/2017 - 18:32 Pro Licensee Comment #20
Would it be much work to have a option to toggle word-wrap on/off? And in off mode get a horizontal scroll in edit window instead? Because sometimes the word/line-wrap makes it really hard to read the code.
//Leffe
Submitted by Blueforce on Sun, 05/14/2017 - 18:41 Pro Licensee Comment #21
The File Manager no longer work when opened in its own tab in browser.
//Leffe
Ready for new level of awesomeness?
Fixed all mentioned bugs + added dropdown menu with yummy stuff for the editor.:
Altto see the magic happening. Besides holdingShiftwill reverse panels arrangement)Screenshot. How is that?
Submitted by Blueforce on Tue, 05/16/2017 - 22:10 Pro Licensee Comment #23
I just had a quick look and it's looking and working really good, you are doing a fantastic job!
I will try it out more later today.
A quick question, is the edit area codemirror based? if so, then it is possible and rather easy to change theme for the editor? The reason for me asking is that I have got a eye problem making it really difficult to work on black or dark background, I always have to use white background. I know codemirror comes with quite a few themes as standard. And then I also can make my own to fit my needs of background color and contents color coding.
Regards, Leffe
Leffe, your eyes will feel better now. ;) I have added back the ability to choose Color Palettes for the editor, but this time, for both Webmin and Usermin users.
I also found few critical bugs that failed File Manager in Usermin work and few more.
Please be kind giving it a heavy test ride.
Everything looks truly fantastic and I'm ready for 18.49 release.
Have a great day, Ilia
Submitted by Blueforce on Wed, 05/17/2017 - 18:51 Pro Licensee Comment #25
Hi Ilia,
Thanks for the ability to change editor theme - Much appreciated!
I have been poking around and trying as much as possible and everything seems to work great!
The only two small things I can say is that
When opening the File Manager in it's own tab it doesn't respect the "expand to full size" add to script.js from start, but when I refresh the tab it does - Not a big deal at all! And it works if the file manager is opened in the right frame first before I right-click and open in a new tab.
The default size of editor should be a bit smaller vertically, the bottom of the editor goes out of and beneath the bottom of the screen (maybe connected to the issue below). In my opinion the optimal/preferred default editor size should be about 50-60% of available frame width and height.
And I also noticed another thing, all contents everywhere in the right frame gets a small scroll, not just the scrollbar everything gets scrollable about 20px even if there is just a few lines in right frame. Is it the screen hight detection that is a bit of? I actually like to have the scrollbar there even if there are no scroll, because I don't like the size jumping around due to scroll or not. But the contents should not be scrollable if not needed.
I'm loving this File Manager more and more each time :-) Fantastic work Ilia!
Regards, Leffe
Submitted by Blueforce on Wed, 05/17/2017 - 19:07 Pro Licensee Comment #26
I forgot to say about the small scroll in the right frame is that if I'm working in file editor and not having a scroll in editor the whole right frame and editor window is jumping up and down when scrolling the mouse wheel. Also not a big deal, just a bit annoying. ;-)
//Leffe
I fixed all of the points you mentioned and it will be added to the final 18.49 release. Background scrolling on opened panels, well, you need to manipulate parent window, basically
<body>but by doing it, there might be issues coming up, like we don't have single panel and many opened at once. The fix to that might be breaking something potentially and I will not do this on the verge of the super-final release.I'm gonna take a short break now, as my head spins already from putting to much effort so quickly, and my back complains a little bit. I will rest, do some family things and come back at the beginning of the next week to continue with adding file differ/merger, tree-view multi-uploads and other top-notch features.
Sincerely, Ilia
18.49 is out.
I also added double click on panel header to normalize/maximize the window, as on regular desktops.
Enjoy.
The set of future improvements is listed on Github: File Manager - Future improvements #629
Submitted by Blueforce on Thu, 05/18/2017 - 19:44 Pro Licensee Comment #31
Hi Ilia,
Thanks! Everything works just fine. You have done a amazing work on the File Manager!
My two "must have" in File Manager is now there, and this makes it possible for me to start working more in the new File Manager, although there are still things missing (in my opinion), but I know they are on your future improvements list.
You marked this as closed and duplicate, do you mean this issue is duplicate with the list on Github? If so, I have to disagree, for me the File Manager is a module in Virtualmin Pro and I think its here I shall post my issues, suggestions and wishes. On Github I can't even comment.
Me to have been working way to much almost a month now and I have not been able to spend and dedicate as much time as I want with my wife (even if we have moved our office to our farm), she had a stroke 4 years ago and got paralyzed on her left side, from head to toe, and are now in a wheelchair!
By the way... you will receive another small donation in a few days! :-)
Regards, Leffe
Leffe, sure. Let's keep it here, if you feel more comfortable.
I am very sorry to hear that your family is going through such difficulties. I wish your wife to recover as much as possible.
Regards, Ilia
Let's move here. This thread has gotten way too long.
File Manager: Future improvements/2 https://virtualmin.com/node/52258