File Manager changes file encoding [#52019]

Submitted by Blueforce on Sat, 04/29/2017 - 16:46 Pro Licensee

Hi,

File manager changes encoding of files on save. When I save a edited file in file manager it changes the file encoding to UTF-8, and makes a total mess in my files! The file encoding must not be changed! Maybe there could be config setting regarding what encoding I want to use as default, with one option like "don't change". I live in Sweden and the encoding change brakes many things in our systems due to our Swedish characters like ÅÄÖ. There are several places I cant use UTF-8 so all my coding is done in ISO-8859-1 / Latin-1.

I use Virtualmin Pro and language is set to English US (EN), not the UTF-8. My computers runs Windows 10 Pro and my browser is Firefox 52.1.0 ESR 32-bit.

I have found a few other issues in Authentic Theme, do you want me to make an issue for each one or can I put them in one issue?

Best regards, Leffe

Status:

Closed (fixed)

Comments

Submitted by Ilia on Sat, 04/29/2017 - 16:49 Comment #1

Alright, I will take a look tomorrow. But I have a question though? What if you switch to the old theme, isn't doing the same??

Yeah go ahead and put it all out here.

Submitted by Blueforce on Sat, 04/29/2017 - 17:03 Pro Licensee Comment #2

Hi, Thanks! No in the old Framed Theme the save works, it does not change the encoding. I just tried in both themes.

//Leffe

Submitted by Ilia on Mon, 05/01/2017 - 08:24 Comment #3

Hi,

Looking at your problem. At first I'd recommend reading this first. #encodeURIComponent using ISO-8859-1 encoding for a javascript string

That might not be easy to do.. but I will look into it more after I come back from training ..

Submitted by Ilia on Mon, 05/01/2017 - 12:05 Comment #4

Here is the fix for you. It's File Manager patch. You would need to use this Pull Request to test it and make sure that it does what you need.

Submitted by Ilia on Mon, 05/01/2017 - 12:05 Comment #5

Status:

Active

» Closed (fixed)

Submitted by Blueforce on Mon, 05/01/2017 - 17:07 Pro Licensee Comment #6

Hi Ilia,

I have now tried the patch and it does work fine! Although I added a semi-colon at the end of new line 31. I also did see that the path was wrong:

!/usr/local/bin/perl

In my case it should be:

!/usr/bin/perl

Thanks! //Leffe

Submitted by Ilia on Mon, 05/01/2017 - 17:13 Comment #7

Yes, thanks. I added semi-column on the other commit few minutes later. For some reason we still have shebang pointing to /local/, I think it should be changed.