GIT user not added to SSL branch of apache config

Submitted by maweber on Sun, 12/11/2016 - 01:48

When creating a git repo in Virtualmin, an SSL connection is not possible because the user entry is missing.

Only for the SSL part in apache config. Unencrypted is working fine

<Location /git/mystuff.git>
Require user {user missing here}
</Location>
  • Webmin version 1.821
  • Virtualmin version 5.05
  • Theme version Authentic Theme 18.31

greets m

Status: 
Active

Comments

Submitted by JamieCameron on Sun, 12/11/2016 - 12:25

Which version of the Virtualmin Git plugin do you have there? I'm not seeing this on my test systems..

You can see the version of the Features and Plugins page.

Submitted by maweber on Sun, 12/11/2016 - 16:35

ok I think I found the "bug" in "virtualmin-git-lib.pl" it said:

push(@port, $d->{'web_sslport'}) if ($d->{'ssl'});

where I guess it should be

push(@ports, $d->{'web_sslport'}) if ($d->{'ssl'});

I corrected it. Now works.

But something strange... I tried updating using

apt-get install webmin-virtualmin-git

And it said version 1.6 was already installed. But as above I should have v1.5. Does that mean there is something fishy with my install?

Is there a way to overwrite/renew the update path? Thanks, best manu

Submitted by JamieCameron on Sun, 12/11/2016 - 18:14

We'll release a new 1.7 version shortly that includes this fix.