Save button on "Edit DNS Records" page doesn't actually save

Submitted by yngens on Thu, 09/22/2016 - 22:25

To replicate the issue, select any virtual server, go to Virtual Server's Configuration > DNS Records > Manually Edit Records, make some changes, click on Save button to get File 'something.tld' has been successfully saved message. Then go to DNS Records page again to see everything is intact as before and nothing has changed.

To make real changes you have to click on "Save on close" button. I don't know why there are two buttons and what is the use of the first one if it doesn't work.

This might quite be an Authentic Theme issue as I haven't tested this using another theme.

Status: 
Closed (fixed)

Comments

Submitted by JamieCameron on Fri, 09/23/2016 - 23:21

Assigned: Unassigned »

Ilia, is this button something the Authentic theme adds? Virtualmin itself doesn't have a separate "Save" and "Save and Close" buttons.

Submitted by yngens on Sat, 10/01/2016 - 15:29

Project: Virtualmin Virtual Servers » Authentic Theme
Body: View changes

I don't think Ilia is following all Virtualmin's issues, so I've re-assigned this ticket to Authentic Theme. Please do the same next time when you believe it's AT issue.

Ilia's picture
Submitted by Ilia on Sun, 10/02/2016 - 02:04

Hi,

Yes it's the theme button. Its purpose is to let user just save changes and continue editing. It has such functionality globally and should just work. I'll double check, thanks for reporting.

Ilia's picture
Submitted by Ilia on Sun, 10/16/2016 - 05:12

Yes, it didn't work because of enctype issue. I fixed it and it'll work as expected in 18.20+.

Thanks for reporting.

Ilia's picture
Submitted by Ilia on Sun, 10/16/2016 - 05:41

Status: Fixed » Closed (fixed)

Ilia's picture
Submitted by Ilia on Sat, 10/29/2016 - 15:33

Version 18.20 is out, please upgrade.