No length value size limitation for "Maximum PHP script run time" field

Submitted by yngens on Fri, 01/15/2016 - 18:37

If you go to Virtualmin, select any virtual server and click on Virtual Server Configuration > Website Options, then you can set some crazy long values for the "Maximum PHP script run time" like, for example, '9999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999' and Virtualmin gladly accepts it:

Changing maximum PHP script run time to 9999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999 seconds ..
.. done
Applying web domain configuration ..
.. done

And if you check the main Apache configuration file then you can find numbers like IPCCommTimeout 1e+169. In some cases it leads to errors like:

> Apache configuration errors were found :
>
> Syntax error on line 1529 of /etc/httpd/conf/httpd.conf:
> FcgidIOTimeout must be greater than 0
> .. your system is not ready for use by Virutalmin.

I believe Virtualmin UI should respect and implement the official recommendations like:

#For fcgid mode, set IPCCommTimeout to either the configured value
#or the PHP max execution time + 1, so that scripts run via fastCGI
#aren't disconnected

and limit the value of this field by default, so that end-users could no chance of entering numbers exceeding the permitted value.

Status: 
Closed (fixed)

Comments

Submitted by JamieCameron on Thu, 02/11/2016 - 00:53

Thanks for the reminder - somehow I completely forgot about this bug.

I will limit the max PHP execution time to 1 day in the next Virtualmin release.

Submitted by JamieCameron on Thu, 02/11/2016 - 00:53

Status: Active ยป Fixed