How to suppress the "Virtualmin 5 comes with a brand new HTML 5 theme! Would you like to try it now?" message

We do really appreciate Ilya's hard work on the Authentic Theme, however we find it really irresponsible for *-min team to offer it to the end-users in so insistive way as to display the following message:

Virtualmin 5 comes with a brand new HTML 5 theme! Would you like to try it now?

because it is not only about missing custom logo as Joe put on https://www.virtualmin.com/node/39225#comment-157946:

I agree that it's important in some deployments, especially for folks selling hosting and wanting to remind folks who they are!

but also lot's of other issues, like for example missing effects of language-files reported on https://www.virtualmin.com/node/39228, which have not been addressed yet. The theme is really cool to start using for individual -min users, however it is a total headache for hosting vendors, which now have to deal with lot's of confused end-user reports.

So please let us know how can we urgently suppress the above message.

And please do not ever again impose some maybe cool, but not fully tested new features because hosting vendors prefer STABILITY in the first place and -min developers should be very cautious when rolling out new features. Ask any hosting vendor and they will confirm how much they dislike when unexpectedly disrupting things happen like this one.

Status: 
Closed (fixed)

Comments

This message only appears for the root user though - so domain owners won't even see it. And if they don't want to switch, they can just click the "Don't Ask Me Again" button.

I think we were pretty gentle about introducing this feature - Virtualmin asks if you want to switch, rather than doing so automatically when upgrading.

This message only appears for the root user though - so domain owners won't even see it. And if they don't want to switch, they can just click the "Don't Ask Me Again" button.

We provide root access to the end users, so this has already started to be a problem for us. "Gentle" for individual users, but not hosting vendors which manage hundreds of customized Virtualmin servers. Expecting all end users to click on "Don't Ask Me Again" is simply not realistic, because people already started to click on that very much inviting theme and then send us lot's of confused messages about terminology on the interface. We would like to suppress that notification and I do hope you can give us such an option. I don't believe it should be a big problem for you to give us a possibility to suppress it.

I do strongly believe Webmin/Virtualmin should have an option to either display or not that kind of messages (regardless of their importance) and if negative option is selected then all future modifications to the system should respect it. It would just make lives of hosting vendors much easier. You simply can not understand how it is frustrating to deal with this kind of imposed options on hundreds of servers.

Also, note that it's possible to switch back to the Virtualmin Framed Theme using the instructions here:

We know that, but again it is not an option. We would like to SUPPRESS this notice until all the issues for the new theme are polished, so that end-users never see any ambiguity.

I ask *min developers to please respect the fact lot's of hosting vendors use your products.

Ilia's picture
Submitted by Ilia on Thu, 01/07/2016 - 10:41

I fully investigated your comments about the two, what you call issues: (#39225 and #39228).

This is not actually exactly like you state for few following reasons.

  1. ...because it is not only about missing custom logo...

Custom logo is not missing. You can setup custom logo in Authentic Theme just the same way (or even better way than before). I also proposed few positive things in the thread you started before (#39225)

  1. ...but also lot's of other issues, like for example missing effects of language-files reported on #39228...

Well, this is not correct. There is no issue at all. I already explained it in the reply of how to use this feature properly. It's not theme related and theme fully supports this. There are few hardcoded lines and I will fit it in the next release. (those lines are not VM related)

From my point of view it's important to move forward and change sometime can be a bit painful. I am opened to any rational suggestions. Anything is doable and possible for conversion/transmission.

There are few hardcoded lines and I will fit it in the next release. (those lines are not VM related)

Дорогой Илья,

Вот пока все эти проблемы не будут решены навязывать новый интерфейс конечным пользователям неприемлемо.

From my point of view it's important to move forward and change sometime can be a bit painful. I am opened to any rational suggestions. Anything is doable and possible for conversion/transmission.

Right, but those kind of changes should always be done on dev branches between developers and tested very well before imposing them to the end-users. And then when you or *-min devs elaborate on this kind of changes for some reason they never put themselves in shoes of hosting vendors, which always try to avoid unnecessary spike of surprised end-user requests. Using cutting-edge technologies is cool for individual users, but definitely not for hosting vendors.

Ilia's picture
Submitted by Ilia on Thu, 01/07/2016 - 16:31

Дорогой Илья, Вот пока все эти проблемы не будут решены навязывать новый интерфейс конечным пользователям неприемлемо.

:) I am not imposing anything on anybody. There are no hardcoded strings that are Virtualmin related. The rest will be fixed in days.

..and tested very well before..

The theme was test thoroughly. Few many hundred bugs were fixed and dozens of releases made before the team decided to make it default in Virtualmin. It's all about we look at the things. The more people use it the better the whole project goes (better for Virtualmin, better for the theme and in the end better for all of us).

In case we're talking about system administrators, from my point of view, quite advanced people in technology, I would expect them to be able easily change back to the previous theme, if they tried and didn't like Authentic Theme. What's more, they can always comment to GitHub or issue tracker with their ideas and what is missing for them. I would like to hear what they say on your behalf and most importantly why they don't like trying new theme and switching back, which only takes less than 30 seconds?

:) I am not imposing anything on anybody. There are no hardcoded strings that are Virtualmin related. The rest will be fixed in days.

It was not your fault personally, but *-min developers as a team. It was really not wise decision to roll this out to the end-users in such an imposing way.

The theme was test thoroughly. Few many hundred bugs were fixed and dozens of releases made before the team decided to make it default in Virtualmin. It's all about we look at the things. The more people use it the better the whole project goes (better for Virtualmin, better for the theme and in the end better for all of us).

In case we're talking about system administrators, from my point of view, quite advanced people in technology, I would expect them to be able easily change back to the previous theme, if they tried and didn't like Authentic Theme. What's more, they can always comment to GitHub or issue tracker with their ideas and what is missing for them. I would like to hear what they say on your behalf and most importantly why they don't like trying new theme and switching back, which only takes less than 30 seconds?

You can not imagine how much I agree with everything said, however please try to understand that end-users are not necessarily system administrators or tech-savvy developers. As a hosting vendor we have to provide root access to our customers, very often just regular account owners without any technical background. And it turns to absolute disaster to us, hosting vendors, when there lot's of such customers who just accept that imposing new theme button and then start complaining about all the confusion they find themselves in.

Believe me - we love the new theme, but as a hosting vendor we need more time to polish all the interface nuances and then preliminarily inform our customer base, write documentation and then only switch everybody to the new theme.

Once again - put yourself in shoes of a hosting vendor and you will understand you never want to put your customers to unexpected situations like this.

Again we are still waiting till Jamie gives us clear instruction on how to suppress that notification on all our Virtualmin servers. Jamie, time is precious in this kind of situations, you have to understand as a creator of Virtualmin. Please do not make us wait any longer or we will have to seriously consider to switching to alternative control panels.

Joe's picture
Submitted by Joe on Thu, 01/07/2016 - 21:59 Pro Licensee

Sorry this has been problematic for your yngens. We never really thought someone with root wouldn't be the right person to talk to about changes. But, we'll help you sort it out. (And language issues are serious. We'll try to sort those out, ASAP.) ;-)

The immediate solution that comes to mind is to run a script that inserts the "theme_switch_authentic-theme" variable into the webmin config file. This seems to be how it knows whether the root user has been asked if they want to switch, or not. I'm doing a test now to see what it inserts (I'm guessing a 1).

So, something like:

# echo "theme_switch_authentic-theme=1">>/etc/webmin/config

And, restart Webmin to reload the config.

I think would make it do the right thing without having to hit the UI. If you've got Webmin setup with all of your servers, you could use the cluster execute command function, I think, to do this across all of them. Or, if you have ssh keys setup, you could do it in a shell script to iterate over all of them.

I haven't tested this yet, so please do test before trying it on all of your servers. ;-)

I'm upgrading the only system I have that isn't already running Authentic and 5.0 now and will see if this is all it takes to make it do the right thing.

Joe's picture
Submitted by Joe on Thu, 01/07/2016 - 22:20 Pro Licensee

Oops, that should be in the virtual-server config file, not the root webmin config file. Also my angle brackets got encoded.

Here's the actual thing (tested and known to work):


# echo "theme_switch_authentic-theme=1" >> /etc/webmin/virtual-server/config

No restart needed, I don't think, as it is a module config that gets loaded on every page load from within that module.

Yeah, adding that theme_switch_authentic-theme=1 line to /etc/webmin/virtual-server/config will prevent this message from appearing.

Yeah, adding that theme_switch_authentic-theme=1 line to /etc/webmin/virtual-server/config will prevent this message from appearing.

Thank you very much, guys!

We do love the new theme and will switch to it very soon. We just need to address some minor issues that are being discussed here in the issue queue.

Another related question is can we explicitly set the theme in /etc/webmin/virtual-server/config file?

I understand you'd like to give freedom of choice to the end-users, however for us as a hosting vendors managing hundred of Virtualmin servers it is best to standardize our workflow and procedures, so hard-setting a specific theme would save us from lot's of troubles. For example, when we figure out how to deal with currently discussed Authentic Theme issues, we would like to set it by default on all our servers seamlessly to our end-users.

I see the webmin_theme=* setting in that file and wonder how it works as changing it to webmin_theme=authentic-theme doesn't have any effect.

Further troubleshooting my last question I've figured out I needed to set theme=authentic-theme, however unfortunately despite new theme loads all the css are gone as shown in the attached screenshot. Restarting webmin doesn't help.

You can set the theme by editing config files - however, you have to set both theme=authentic-theme in /etc/webmin/config , and preroot=authentic-theme in /etc/webmin/miniserv.conf , then run /etc/webmin/restart

Ilia's picture
Submitted by Ilia on Sun, 01/10/2016 - 16:23

It's fixed in 17.40. custom document buttons are respected, obsolete logo settings are removed. ALL language strings are now configurable, as were dehardcoded from both JavaScript and Perl files.

Please upgrade.

Ilia's picture
Submitted by Ilia on Fri, 02/19/2016 - 01:26

Assigned: Unassigned »
Status: Active » Closed (fixed)