Virtualmin-git, doesnt add users to apache ssl-entry

Submitted by GiaeverPubl on Tue, 04/21/2015 - 04:19

Using the Virtualmin-git module, and have SSL enabled. The module doesn't add users to the ssl entry in apache, only to the non-ssl entry.

The only thing that is present is this (users missing):

<!-- None anonymous access -->
<Location /git/test.git>
    Require user
</Location>

<!-- With anonymous access -->
<Location /git/test2.git>
    <LimitExcept GET HEAD PROPFIND OPTIONS REPORT>
        Require user
    </LimitExcept>
    <Limit GET HEAD PROPFIND OPTIONS REPORT>
        Satisfy Any
    </Limit>
</Location>

While the non-ssl entry is this:

<!-- None anonymous access -->
<Location /git/test.git>
    Require user joachim
</Location>

<!-- With anonymous access -->
<Location /git/test2.git>
    <LimitExcept GET HEAD PROPFIND OPTIONS REPORT>
        Require user joachim
    </LimitExcept>
    <Limit GET HEAD PROPFIND OPTIONS REPORT>
        Satisfy Any
    </Limit>
</Location>
Status: 
Closed (fixed)

Comments

Submitted by GiaeverPubl on Tue, 04/21/2015 - 04:36

Found the bug; virtualmin-git-lib.pl, line 225:

push(@port, $d->{'web_sslport'}) if ($d->{'ssl'});

must be changed to

push(@ports, $d->{'web_sslport'}) if ($d->{'ssl'});

from @port to @ports

Submitted by JamieCameron on Tue, 04/21/2015 - 21:31

Thanks! I will include this fix in the next release of the Git plugin.

Submitted by Issues on Tue, 05/05/2015 - 21:40

Automatically closed -- issue fixed for 2 weeks with no activity.