Two issues with Webmin modules assigned to server owners

Submitted by Locutus on Thu, 12/23/2010 - 19:56

This bug report stems from a forum thread, so please allow me to link to what I wrote there:

http://www.virtualmin.com/node/13230#comment-73968

Status: 
Closed (fixed)

Comments

Submitted by JamieCameron on Fri, 12/24/2010 - 01:17

a) Not all Webmin modules show up in Vmin's "Webmin Modules" list, e.g. "Linux RAID" and "ADSL Client" (that's two of those I tested) show up only when I set the left-menu mode to "Webmin".

That is intentional .. only those modules which Virtualmin knows how to limit the capabilities of the domain owner on will show up. Giving a domain owner access to the Linux RAID module would be a really bad idea, as he could wipe out the whole system.

b) When I change the available modules for server owners, under System Settings -> Virtualmin Config -> Server administrator permissions : Extra Webmin modules..., the changes are (at least partially) not applied to existing Webmin users. Same examples as above... "Linux RAID" and "ADSL Client", which I activated as a test, were not turned on for existing Webmin users although Update all Webmin users was set to "Yes". I had to turn off and on the feature "Webmin login" for the domain in question, and then the newly created Webmin user had the correct module rights set.

That's also expected, as templates define what settings new users get. For existing users you can change their modules at Administration Options -> Edit Owner Limits.

Submitted by Locutus on Fri, 12/24/2010 - 04:16

Okidoki.

One thing you might consider is adding a hint that Update all Webmin users will not automatically assign them the right defined in the "Server administrator permissions" page...

"Update all" sounds a bit confusing in that regard, since it's not on a template page but on the System Configuration one.

Submitted by JamieCameron on Sat, 12/25/2010 - 00:00

Actually, with that option set any webmin modules should get granted to all users, as soon as you perform a configuration re-check.

Submitted by Locutus on Sat, 12/25/2010 - 04:51

Yep, it should, but it doesn't. :) Just tested it again, with the "dangerous" example Linux RAID.

(I know it's a bad idea to give that to server owners - but there might be a situation where a server owner SHOULD get access to that module, and in that case I think the function should behave as expected. :) )

Submitted by JamieCameron on Mon, 12/27/2010 - 00:44

Just to double-check - which page exactly did you grant access to the "Linux RAID" module on?

Submitted by Locutus on Mon, 12/27/2010 - 04:15

Sure, lemme copy+paste (and adjust a bit) from the Forum post. ;)

I went to System Settings -> Virtualmin Config -> Server administrator permissions : Extra Webmin modules for server administrators and added "Linux RAID" there.

The change was not applied to existing Webmin users, although Update all Webmin users was set to "Yes" (and the yellow "Configuration recheck required" box popped up).

After turning the feature "Webmin login" for the domain in question off and on, the newly created Webmin user had the correct module rights set.

(I did this test on my experimental VM btw., so even if the server owner in question got wind of it, they couldn't trash anything important. ;))

Submitted by JamieCameron on Tue, 12/28/2010 - 13:08

Ok, I see the cause of this bug now .. webmin users aren't being re-updated properly when you do the config check. I will fix this in the next virtualmin release.