Statistics page for VPS fails to load due to an error under certain conditions

Hi,

Thanks for reporting. I have fixed that issue on our repos but you would have manually open:

/usr/libexec/webmin/server-manager/one_history.cgi

and move

$stat_to_axis{$stat} = "value".$axis;

..one line up, so it looks like this:

print "        $maxopt\n";
		print "        min: 0\n";
		print "      });\n";
		$stat_to_axis{$stat} = "value".$axis;
		}
	}

# Generate JS for each stat

..I given that more tests and it seems incorrect. :(

I will have a closer look tomorrow.

Okay, fixed finally.

Jamie, I don't see how would that be possible to make it work otherwise. Some data cannot be combined. At the same time it satisfies Timeplot and that's okay for now.

@thedaemexco

To fix this, find in earlier mentioned file:

foreach $stat (@stats) {
	$maxopt = "";
	$fmt = &historic_stat_info($stat, $maxes);
	if ($maxes->{$stat}) {
		$maxv = $maxes->{$stat};
		$maxv /= $fmt->{'scale'} if ($fmt && $fmt->{'scale'});
		$maxopt = "max: $maxv,";
		}
	$units = $fmt ? $fmt->{'units'} : "count";
	$axis = &indexof($units, @axes);
	if ($axis < 0) {
		# New axis
		$axis = scalar(@axes);
		push(@axes, $units);
		if ($axis == 0) {
			$place = "left";
			}
		elsif ($axis == 1) {
			$place = "right";
			}
		else {
			next;
			}
		print "var value$axis = new Timeplot.$geom({\n";
		print "        gridColor: '#B3B6B0',\n";
		print "        axisLabelsPlacement: '$place',\n";
		print "        $maxopt\n";
		print "        min: 0\n";
		print "      });\n";
		}
	$stat_to_axis{$stat} = "value".$axis;
	}

.. and replace with:

my $ii = 0;
foreach $stat (@stats) {
	$maxopt = "";
	$fmt = &historic_stat_info($stat, $maxes);
	if ($maxes->{$stat}) {
		$maxv = $maxes->{$stat};
		$maxv /= $fmt->{'scale'} if ($fmt && $fmt->{'scale'});
		$maxopt = "max: $maxv,";
		}
	$units = $fmt ? $fmt->{'units'} : "count";
	$axis = &indexof($units, @axes);
	if ($axis < 0) {
		# New axis
		$axis = scalar(@axes);
		push(@axes, $units);
		if ($axis == 0) {
			$place = "left";
			}
		elsif ($axis == 1) {
			$place = "right";
			}
		else {
			next;
			}
		}
		print "var value${axis}${ii} = new Timeplot.$geom({\n";
		print "        gridColor: '#B3B6B0',\n";
		print "        axisLabelsPlacement: '$place',\n";
		print "        $maxopt\n";
		print "        min: 0\n";
		print "      });\n";
	$stat_to_axis{$stat} = "value${axis}${ii}";
	$ii++;
	}

Ilia - what two kinds of stats cannot be combined in this case?

I can't see how that code change would help, because $stat and $axis are going to end up with the same values regardless.

I can't see how that code change would help, because $stat and $axis are going to end up with the same values regardless.

Not exactly, there is valueX clash.

Try selecting the following or use this URL to see how it fails with an old code:

or select at the same time:

CPU IO wait time, Disk used percent, Memory free, Memory limit.

The same happened on Virtualmin.

Odd, I wasn't able to reproduce this - bug if it works, great! Ilia, can you check this fix in?

Odd, I wasn't able to reproduce this - bug if it works, great!

Jamie, try to pick more stats to display at one time.

Ilia, can you check this fix in?

Yes, Jamie, I already did @fcab395 and @7f9ef49

Great, thanks!