Allow regular users to restore their own domains

On a Virtualmin system configured to take regular backups for all the websites and admin user can easily view backup logs and/or restore websites. However, all the regular users see on backups logs is a message:

No backups that you have access to have been logged.

Right, because they do not have access to the backup directory, which belongs to root user and group. So what is the best way of scheduling backups for all the websites and at the same time to make it possible for website owners to be able to restore their websites?

Status: 
Closed (duplicate)

Comments

This happens because only backups made by the domain owner are shown in the logs. There is an open feature request to allow them to restore backups made by root (see https://www.virtualmin.com/node/56973) , but it's complex due to potential risks of allowing restoration of arbitrary backup files.

Status: Active » Closed (duplicate)

I forget I created similar issues because they are not resolved for long long months. So sad...

Status: Closed (duplicate) » Active

Hi Jamie,

Since the other issue on https://www.virtualmin.com/node/56973 is closed for commenting I had to re-open this one.

I've noticed the Can restore backups made by master admin? option in Virtualmin configuration page today and clicking on it gives:

By default, virtual server owners can only restore backups that they made themselves. However, if this setting is changed to Yes, backups made by the master administrator (root) can also be restored by domain owners. Naturally this only applies to their own domains though. You should only enable this option if you are sure that all your backup destinations are secure, as restoring a backup made by an un-trusted user could compromise system security.

So can you officially confirm virtual server owners can restore their backups made by superadmin?

Joe's picture
Submitted by Joe on Mon, 10/15/2018 - 20:42 Pro Licensee

I'm not sure I understand what you're asking for here. The documentation seems pretty clear that that's exactly what it does?

Joe, the last update from your team on the subject on https://www.virtualmin.com/node/56973 was:

This is on the todo list, but we do not currently have an ETA

and since we can not comment on the other subject anymore, I'd like to hear it has really been implemented. The official confirmation of implementation of requested feature by *min authorities always eliminates doubts we could have otherwise: was it really done or we are witnessing some kind of temporary bug or something.

I made a backup as master admin and then login in as regular user to see I could restore the backup. Which is really cool. But could I confirm I am not mistaken here?

Joe's picture
Submitted by Joe on Tue, 10/16/2018 - 00:34 Pro Licensee

The last update was "Fixed", though, right? So, the docs say it's there, the ticket about it says "fixed". It seems pretty clear it's been implemented. I didn't implement it, and I haven't tried it, but I can't imagine why it would be marked fixed and the docs would say it works, if it isn't and doesn't. And...you say you're seeing the feature in the UI. It seems like all signs point to "yes".

Fair enough, though I thought the other issue was closed because you, guys, got mad at me and because the subject matter was properly addressed. Anyway, I will run more tests since didn't get explicit confirmation from you.

Joe's picture
Submitted by Joe on Tue, 10/16/2018 - 16:33 Pro Licensee

I would think it would have been marked "Won't fix" if it were just grumpy admins. I didn't set the status on that ticket, but I think that'd be the right status for "I'm annoyed" situations.

So the option mentioned in comment #3 isn't exactly what was originally requested, as it doesn't allow domain owners to restore backups from arbitrary locations.

The original request IS still being worked on, but I'm being very careful with it because there are security implications if a modified backup is restored. Likely I will limit this to signed backups.