Can't override "Search Webmin"

Tying to override the "Search Webmin" on webmin_search.cgi page by using language files, but can't find it anywhere. Could you please tell how to get this one translated?

Status: 
Closed (fixed)

Comments

Assigned: Unassigned »
Joe's picture
Submitted by Joe on Sun, 10/28/2018 - 22:48 Pro Licensee

It's in the theme lang files. But, it's not that exact string in Authentic. It's just "Search". The ID is "left_search". I guess the name of the thing to search is generated in code in Authentic theme.

Looks like that's here: https://github.com/authentic-theme/authentic-theme/blob/655de0ec5e84fb9f...

The names of Webmin, Usermin, and Virtualmin are hardcoded, since they don't internationalize (because Webmin in French is still "Webmin").

Joe's picture
Submitted by Joe on Sun, 10/28/2018 - 22:48 Pro Licensee

What are you trying to accomplish?

Project: Webmin Core » Authentic Theme
The names of Webmin, Usermin, and Virtualmin are hardcoded, since they don't internationalize (because Webmin in French is still "Webmin").

In fact, if you read https://www.virtualmin.com/node/39228 then you'll see we've been overriding lot's of strings on Webmin/Virtualmin UI since long time. We do that for several reasons of our own, some of which are:

  • some of the terms are not correct (just read an example on https://www.virtualmin.com/node/43072);
  • even if they are correct, some we find not appealing than customized ones;
  • we are trying to make it easy for control panel customers who are used to such terms like domain (instead of virtual server), park domain (create alias), etc;

The names of Webmin, Virtualmin, Cloudmin, Usermin themeselves have been perfectly overridable (translatable) too, so I don't see any reason why Search Webmin should not be.

Ilia, can you please take a look at this? Thanks!

In other words, we are not internationalizing, but rather customizing UI terms to make it more comfortable and appealing to our end users.

Ilia's picture
Submitted by Ilia on Mon, 10/29/2018 - 04:24

It's part of Webmin core.

https://github.com/webmin/webmin/blob/master/lang/en#L319

..and here is the line you're talking about: https://github.com/webmin/webmin/blob/master/webmin_search.cgi#L15

Looking at the code and seeing the title produced, I see the space for improvement.

I made all labels around, including Webmin, to be a subject for change: https://github.com/authentic-theme/authentic-theme/blob/master/lang/en.U...

Project: Authentic Theme » Webmin Core

After Ilia confirmed:

It's part of Webmin core.

I am changing the project of the issue back to Webmin.

Ilia's picture
Submitted by Ilia on Mon, 10/29/2018 - 04:46

..but I didn't say the theme can not manipulate the title.

It is possible to pass the title, as you can see in the code:

$in{'title'}) || &text('wsearch_title', $ucprod)

I will do it.

Any suggestions how the title should look like?

Project: Webmin Core » Authentic Theme
..but I didn't say the theme can not manipulate the title. It is possible to pass the title... I will do it.

Oh, I was confused, so in that case let's change the issue project once again.

Any suggestions how the title should look like?

I think ideally that particular page's title should take in any customizations made for word Webmin in /etc/webmin/custom-lang file, which has a line:

main_title2=Custom Title

So your manipulation of the page's title should be composed of words Search and the value of main_title2 taken from /etc/webmin/custom-lang file. What do you think?

Joe's picture
Submitted by Joe on Mon, 10/29/2018 - 17:57 Pro Licensee

I don't really love the idea of folks changing the name of Webmin/Virtualmin/Cloudmin. Brand awareness is nearly the only asset we have, and the only value we get from people using the free versions of stuff. We can't stop it, of course, it's Open Source and people have done it regularly for various embedded uses of Webmin/Virtualmin over the years, but I'm not terribly happy about it, either. It says something negative one way or another...like, you don't want your customers to know it's Webmin/Virtualmin.

Joe's picture
Submitted by Joe on Mon, 10/29/2018 - 17:58 Pro Licensee

But, if we're gonna make it customizable, I guess it ought to be at the Webmin level, rather than theme, since the names are coming from Webmin (but, if that's the case, why is there code explicitly setting the variables being used in the theme?).

Ilia's picture
Submitted by Ilia on Tue, 10/30/2018 - 01:06

Joe, I also agree with you about re-branding topic. It shouldn't be done completely. At the same time, it wouldn't be possible to accomplish rebranding that much, so customers wouldn't know completely which panel are they using.

By the way, it might be violation of MIT license.

why is there code explicitly setting the variables being used in the theme?

Bacause theme needs such labels and uses them. For example, in the navigation menu switch (Webmin, Virtualmin, and etc) - in the past there were complains and discussions about them being hardcoded. The only logical thing was to put them in the language file.

We disclose we rely on Virtualmin everywhere (https://www.google.com/search?q=site%3Adrupion.com+virtualmin&oq=site%3A...) and even refer to Virtualmin.com documentation, so our customers are very well aware they are using Webmin/Virtualmin. The problem is not there, Joe, at all. We are changing terms on UI just because we would like to make it more appealing and easier for our customers. Anyway, it has been possible to change the UI strings before and it's just wrong letting to change it everywhere and not letting change it at one particular page. Things must be consistent - either do not let override strings anywhere or let override everywhere.

Ilia's picture
Submitted by Ilia on Tue, 10/30/2018 - 08:22

Status: Active » Fixed (pending)
Ilia's picture
Submitted by Ilia on Tue, 10/30/2018 - 08:23

By the way, screenshots in your docs.drupion.com are made with old theme.

Ilia, I tried to test this by pulling git version of the theme, but it still gives 19.20-beta6, so no change yet for the subject matter.

Regarding our documentation I know it is quite outdated, but we are re-branding our company soon, so everything will be different.

Ilia's picture
Submitted by Ilia on Tue, 10/30/2018 - 09:36

Try pulling it again.

It'll work.

Should the version change, because pulling it again shows Updating to Authentic Theme 19.20-beta6, done. and then I made sure the translation files have "Search Webmin" replacement, but it still shows the same string.

Ilia's picture
Submitted by Ilia on Tue, 10/30/2018 - 16:45

Yes, the major version is beta6, while minor version is 12. Check theme.info file for more details.

I will probably add minor version to console output as well tomorrow.

I pull an update to my dev server, each time I push a change to the repo, to make a quadruple-test.

It just should work. Labels are in the files.

Tested right now again and it works like a charm. Thanks a lot, Ilia!

Ilia's picture
Submitted by Ilia on Sun, 12/23/2018 - 02:29

Status: Fixed (pending) » Fixed
Ilia's picture
Submitted by Ilia on Sun, 12/23/2018 - 02:33

Status: Fixed » Closed (fixed)